Rename ErrCampaignNoSourcesSelected to ErrCampaignMissingSources

The failure is about unconfigured campaign sources, not an empty UI
selection.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>

pkg/accessreview/campaign_service.go

@@ -429,7 +429,7 @@ func (s *Service) StartCampaign(
 			}
 
 			if len(campaignSources) == 0 {
-				return ErrCampaignNoSourcesSelected
+				return ErrCampaignMissingSources
 			}
 
 			now := time.Now()

pkg/accessreview/errors.go

@@ -23,6 +23,6 @@ package accessreview
 import "errors"
 
 var (
-	ErrCampaignNoSourcesSelected = errors.New("cannot start campaign: no scope sources configured")
+	ErrCampaignMissingSources = errors.New("cannot start campaign: no scope sources configured")
 	ErrCampaignNotDraft          = errors.New("campaign must be in draft status")
 )

pkg/server/api/console/v1/access_review_campaign_resolvers.go

@@ -805,7 +805,7 @@ func (r *mutationResolver) StartAccessReviewCampaign(ctx context.Context, input
 
 	campaign, err := r.accessReview.StartCampaign(ctx, scope, input.AccessReviewCampaignID)
 	if err != nil {
-		if errors.Is(err, accessreview.ErrCampaignNoSourcesSelected) ||
+		if errors.Is(err, accessreview.ErrCampaignMissingSources) ||
 			errors.Is(err, accessreview.ErrCampaignNotDraft) {
 			return nil, gqlutils.Invalid(ctx, err)
 		}