From eabd0fb6597753545baa3f50c58d2e229eaafd93 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Mon, 20 Jul 2026 15:47:27 +0000 Subject: [PATCH] Rename ErrCampaignNoSourcesSelected to ErrCampaignMissingSources The failure is about unconfigured campaign sources, not an empty UI selection. Signed-off-by: Cursor Agent Co-authored-by: Bryan FRIMIN --- pkg/accessreview/campaign_service.go | 2 +- pkg/accessreview/errors.go | 2 +- pkg/server/api/console/v1/access_review_campaign_resolvers.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/accessreview/campaign_service.go b/pkg/accessreview/campaign_service.go index 45ac9be3a..336e8d396 100644 --- a/pkg/accessreview/campaign_service.go +++ b/pkg/accessreview/campaign_service.go @@ -429,7 +429,7 @@ func (s *Service) StartCampaign( } if len(campaignSources) == 0 { - return ErrCampaignNoSourcesSelected + return ErrCampaignMissingSources } now := time.Now() diff --git a/pkg/accessreview/errors.go b/pkg/accessreview/errors.go index af199571e..b8f1caea1 100644 --- a/pkg/accessreview/errors.go +++ b/pkg/accessreview/errors.go @@ -23,6 +23,6 @@ package accessreview import "errors" var ( - ErrCampaignNoSourcesSelected = errors.New("cannot start campaign: no scope sources configured") + ErrCampaignMissingSources = errors.New("cannot start campaign: no scope sources configured") ErrCampaignNotDraft = errors.New("campaign must be in draft status") ) diff --git a/pkg/server/api/console/v1/access_review_campaign_resolvers.go b/pkg/server/api/console/v1/access_review_campaign_resolvers.go index 87f10eec3..ec8dcb88d 100644 --- a/pkg/server/api/console/v1/access_review_campaign_resolvers.go +++ b/pkg/server/api/console/v1/access_review_campaign_resolvers.go @@ -805,7 +805,7 @@ func (r *mutationResolver) StartAccessReviewCampaign(ctx context.Context, input campaign, err := r.accessReview.StartCampaign(ctx, scope, input.AccessReviewCampaignID) if err != nil { - if errors.Is(err, accessreview.ErrCampaignNoSourcesSelected) || + if errors.Is(err, accessreview.ErrCampaignMissingSources) || errors.Is(err, accessreview.ErrCampaignNotDraft) { return nil, gqlutils.Invalid(ctx, err) }