rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix missing risk validations

Browse Source 
Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2026-02-16 15:17:54 +01:00
parent ea01eeca9d
commit 8199e64711
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/probo/risk_service.go
View File

@@ -64,8 +64,8 @@ func (crr *CreateRiskRequest) Validate() error {
v := validator.New()
v.Check(crr.OrganizationID, "organization_id", validator.Required(), validator.GID(coredata.OrganizationEntityType))
v.Check(crr.Name, "name", validator.SafeTextNoNewLine(TitleMaxLength))
v.Check(crr.Description, "description", validator.Required(), validator.SafeText(ContentMaxLength))
v.Check(crr.Name, "name", validator.Required(), validator.SafeTextNoNewLine(TitleMaxLength))
v.Check(crr.Description, "description", validator.SafeText(ContentMaxLength))
v.Check(crr.Category, "category", validator.Required(), validator.SafeText(TitleMaxLength))
v.Check(crr.Treatment, "treatment", validator.Required(), validator.OneOfSlice(coredata.RiskTreatments()))
v.Check(crr.OwnerID, "owner_id", validator.GID(coredata.MembershipProfileEntityType))
@@ -418,6 +418,10 @@ func (s RiskService) Create(
ctx context.Context,
req CreateRiskRequest,
) (*coredata.Risk, error) {
if err := req.Validate(); err != nil {
return nil, fmt.Errorf("invalid request: %w", err)
}
now := time.Now()
owner := coredata.MembershipProfile{}
organization := coredata.Organization{}
@@ -498,6 +502,10 @@ func (s RiskService) Update(
ctx context.Context,
req UpdateRiskRequest,
) (*coredata.Risk, error) {
if err := req.Validate(); err != nil {
return nil, fmt.Errorf("invalid request: %w", err)
}
risk := &coredata.Risk{ID: req.ID}
err := s.svc.pg.WithTx(