From 8199e6471165a0e05bfa10b95c8483af87744146 Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Mon, 16 Feb 2026 15:17:54 +0100 Subject: [PATCH] Fix missing risk validations Signed-off-by: Sacha Al Himdani --- pkg/probo/risk_service.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/pkg/probo/risk_service.go b/pkg/probo/risk_service.go index 6a1f3754d..88670a7bc 100644 --- a/pkg/probo/risk_service.go +++ b/pkg/probo/risk_service.go @@ -64,8 +64,8 @@ func (crr *CreateRiskRequest) Validate() error { v := validator.New() v.Check(crr.OrganizationID, "organization_id", validator.Required(), validator.GID(coredata.OrganizationEntityType)) - v.Check(crr.Name, "name", validator.SafeTextNoNewLine(TitleMaxLength)) - v.Check(crr.Description, "description", validator.Required(), validator.SafeText(ContentMaxLength)) + v.Check(crr.Name, "name", validator.Required(), validator.SafeTextNoNewLine(TitleMaxLength)) + v.Check(crr.Description, "description", validator.SafeText(ContentMaxLength)) v.Check(crr.Category, "category", validator.Required(), validator.SafeText(TitleMaxLength)) v.Check(crr.Treatment, "treatment", validator.Required(), validator.OneOfSlice(coredata.RiskTreatments())) v.Check(crr.OwnerID, "owner_id", validator.GID(coredata.MembershipProfileEntityType)) @@ -418,6 +418,10 @@ func (s RiskService) Create( ctx context.Context, req CreateRiskRequest, ) (*coredata.Risk, error) { + if err := req.Validate(); err != nil { + return nil, fmt.Errorf("invalid request: %w", err) + } + now := time.Now() owner := coredata.MembershipProfile{} organization := coredata.Organization{} @@ -498,6 +502,10 @@ func (s RiskService) Update( ctx context.Context, req UpdateRiskRequest, ) (*coredata.Risk, error) { + if err := req.Validate(); err != nil { + return nil, fmt.Errorf("invalid request: %w", err) + } + risk := &coredata.Risk{ID: req.ID} err := s.svc.pg.WithTx(