Simplify PostHog region select rendering

Replace the nested ternary in the extra-settings map with an
early-return body and a shared setter, so the region select and the
free-text field each read cleanly.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>

apps/console/src/pages/organizations/access-reviews/dialogs/AddAccessSourceDialog.tsx

@@ -586,39 +586,40 @@ export function AddAccessSourceDialog({
               required
               autoFocus
             />
-            {activeProvider?.extraSettings.map(setting =>
+            {activeProvider?.extraSettings.map((setting) => {
-              setting.key === "region"
+              const value = extraSettingValues[setting.key] ?? "";
-                ? (
+              const setValue = (next: string) =>
-                    <div key={setting.key} className="space-y-1.5">
+                setExtraSettingValues(prev => ({ ...prev, [setting.key]: next }));
-                      <label className="text-sm font-medium">{__(setting.label)}</label>
+
-                      <Select
+              // The "region" setting is a fixed US/EU choice; every other
-                        value={extraSettingValues[setting.key] ?? ""}
+              // extra setting is a free-text field.
-                        onValueChange={(val: string) =>
+              if (setting.key === "region") {
-                          setExtraSettingValues(prev => ({
+                return (
-                            ...prev,
+                  <div key={setting.key} className="space-y-1.5">
-                            [setting.key]: val,
+                    <label className="text-sm font-medium">{__(setting.label)}</label>
-                          }))}
+                    <Select
-                        placeholder={__("Select a region")}
+                      value={value}
-                      >
+                      onValueChange={setValue}
-                        <Option value="US">{__("United States (US)")}</Option>
+                      placeholder={__("Select a region")}
-                        <Option value="EU">{__("Europe (EU)")}</Option>
+                    >
-                      </Select>
+                      <Option value="US">{__("United States (US)")}</Option>
-                    </div>
+                      <Option value="EU">{__("Europe (EU)")}</Option>
-                  )
+                    </Select>
-                : (
+                  </div>
-                    <Field
+                );
-                      key={setting.key}
+              }
-                      label={__(setting.label)}
+
-                      value={extraSettingValues[setting.key] ?? ""}
+              return (
-                      onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
+                <Field
-                        setExtraSettingValues(prev => ({
+                  key={setting.key}
-                          ...prev,
+                  label={__(setting.label)}
-                          [setting.key]: e.target.value,
+                  value={value}
-                        }))}
+                  onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
-                      required={setting.required}
+                    setValue(e.target.value)}
-                    />
+                  required={setting.required}
-                  ),
+                />
-            )}
+              );
+            })}
           </DialogContent>
           <DialogFooter>
             <Button