rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Simplify PostHog region select rendering

Browse Source 
Replace the nested ternary in the extra-settings map with an
early-return body and a shared setter, so the region select and the
free-text field each read cleanly.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-05-29 13:57:37 +02:00
parent e4f247a20d
commit 760f950a48
1 changed files with 34 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
apps/console/src/pages/organizations/access-reviews/dialogs/AddAccessSourceDialog.tsx
View File

@@ -586,39 +586,40 @@ export function AddAccessSourceDialog({
required
autoFocus
/>
{activeProvider?.extraSettings.map(setting =>
setting.key === "region"
? (
<div key={setting.key} className="space-y-1.5">
<label className="text-sm font-medium">{__(setting.label)}</label>
<Select
value={extraSettingValues[setting.key] ?? ""}
onValueChange={(val: string) =>
setExtraSettingValues(prev => ({
...prev,
[setting.key]: val,
}))}
placeholder={__("Select a region")}
>
<Option value="US">{__("United States (US)")}</Option>
<Option value="EU">{__("Europe (EU)")}</Option>
</Select>
</div>
)
: (
<Field
key={setting.key}
label={__(setting.label)}
value={extraSettingValues[setting.key] ?? ""}
onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
setExtraSettingValues(prev => ({
...prev,
[setting.key]: e.target.value,
}))}
required={setting.required}
/>
),
)}
{activeProvider?.extraSettings.map((setting) => {
const value = extraSettingValues[setting.key] ?? "";
const setValue = (next: string) =>
setExtraSettingValues(prev => ({ ...prev, [setting.key]: next }));
// The "region" setting is a fixed US/EU choice; every other
// extra setting is a free-text field.
if (setting.key === "region") {
return (
<div key={setting.key} className="space-y-1.5">
<label className="text-sm font-medium">{__(setting.label)}</label>
<Select
value={value}
onValueChange={setValue}
placeholder={__("Select a region")}
>
<Option value="US">{__("United States (US)")}</Option>
<Option value="EU">{__("Europe (EU)")}</Option>
</Select>
</div>
);
}
return (
<Field
key={setting.key}
label={__(setting.label)}
value={value}
onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
setValue(e.target.value)}
required={setting.required}
/>
);
})}
</DialogContent>
<DialogFooter>
<Button