From 760f950a48f052292c73ed13a52d85f8a0f83fcd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Sibiril?=
 <81782+aureliensibiril@users.noreply.github.com>
Date: Fri, 29 May 2026 13:57:37 +0200
Subject: [PATCH] Simplify PostHog region select rendering
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Replace the nested ternary in the extra-settings map with an
early-return body and a shared setter, so the region select and the
free-text field each read cleanly.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
---
 .../dialogs/AddAccessSourceDialog.tsx         | 67 ++++++++++---------
 1 file changed, 34 insertions(+), 33 deletions(-)

diff --git a/apps/console/src/pages/organizations/access-reviews/dialogs/AddAccessSourceDialog.tsx b/apps/console/src/pages/organizations/access-reviews/dialogs/AddAccessSourceDialog.tsx
index 0995940d4..0095e079a 100644
--- a/apps/console/src/pages/organizations/access-reviews/dialogs/AddAccessSourceDialog.tsx
+++ b/apps/console/src/pages/organizations/access-reviews/dialogs/AddAccessSourceDialog.tsx
@@ -586,39 +586,40 @@ export function AddAccessSourceDialog({
               required
               autoFocus
             />
-            {activeProvider?.extraSettings.map(setting =>
-              setting.key === "region"
-                ? (
-                    <div key={setting.key} className="space-y-1.5">
-                      <label className="text-sm font-medium">{__(setting.label)}</label>
-                      <Select
-                        value={extraSettingValues[setting.key] ?? ""}
-                        onValueChange={(val: string) =>
-                          setExtraSettingValues(prev => ({
-                            ...prev,
-                            [setting.key]: val,
-                          }))}
-                        placeholder={__("Select a region")}
-                      >
-                        <Option value="US">{__("United States (US)")}</Option>
-                        <Option value="EU">{__("Europe (EU)")}</Option>
-                      </Select>
-                    </div>
-                  )
-                : (
-                    <Field
-                      key={setting.key}
-                      label={__(setting.label)}
-                      value={extraSettingValues[setting.key] ?? ""}
-                      onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
-                        setExtraSettingValues(prev => ({
-                          ...prev,
-                          [setting.key]: e.target.value,
-                        }))}
-                      required={setting.required}
-                    />
-                  ),
-            )}
+            {activeProvider?.extraSettings.map((setting) => {
+              const value = extraSettingValues[setting.key] ?? "";
+              const setValue = (next: string) =>
+                setExtraSettingValues(prev => ({ ...prev, [setting.key]: next }));
+
+              // The "region" setting is a fixed US/EU choice; every other
+              // extra setting is a free-text field.
+              if (setting.key === "region") {
+                return (
+                  <div key={setting.key} className="space-y-1.5">
+                    <label className="text-sm font-medium">{__(setting.label)}</label>
+                    <Select
+                      value={value}
+                      onValueChange={setValue}
+                      placeholder={__("Select a region")}
+                    >
+                      <Option value="US">{__("United States (US)")}</Option>
+                      <Option value="EU">{__("Europe (EU)")}</Option>
+                    </Select>
+                  </div>
+                );
+              }
+
+              return (
+                <Field
+                  key={setting.key}
+                  label={__(setting.label)}
+                  value={value}
+                  onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
+                    setValue(e.target.value)}
+                  required={setting.required}
+                />
+              );
+            })}
           </DialogContent>
           <DialogFooter>
             <Button