Simplify PostHog region select rendering

Replace the nested ternary in the extra-settings map with an
early-return body and a shared setter, so the region select and the
free-text field each read cleanly.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-05-29 13:57:37 +02:00
parent e4f247a20d
commit 760f950a48

View File

@@ -586,39 +586,40 @@ export function AddAccessSourceDialog({
required required
autoFocus autoFocus
/> />
{activeProvider?.extraSettings.map(setting => {activeProvider?.extraSettings.map((setting) => {
setting.key === "region" const value = extraSettingValues[setting.key] ?? "";
? ( const setValue = (next: string) =>
setExtraSettingValues(prev => ({ ...prev, [setting.key]: next }));
// The "region" setting is a fixed US/EU choice; every other
// extra setting is a free-text field.
if (setting.key === "region") {
return (
<div key={setting.key} className="space-y-1.5"> <div key={setting.key} className="space-y-1.5">
<label className="text-sm font-medium">{__(setting.label)}</label> <label className="text-sm font-medium">{__(setting.label)}</label>
<Select <Select
value={extraSettingValues[setting.key] ?? ""} value={value}
onValueChange={(val: string) => onValueChange={setValue}
setExtraSettingValues(prev => ({
...prev,
[setting.key]: val,
}))}
placeholder={__("Select a region")} placeholder={__("Select a region")}
> >
<Option value="US">{__("United States (US)")}</Option> <Option value="US">{__("United States (US)")}</Option>
<Option value="EU">{__("Europe (EU)")}</Option> <Option value="EU">{__("Europe (EU)")}</Option>
</Select> </Select>
</div> </div>
) );
: ( }
return (
<Field <Field
key={setting.key} key={setting.key}
label={__(setting.label)} label={__(setting.label)}
value={extraSettingValues[setting.key] ?? ""} value={value}
onChange={(e: React.ChangeEvent<HTMLInputElement>) => onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
setExtraSettingValues(prev => ({ setValue(e.target.value)}
...prev,
[setting.key]: e.target.value,
}))}
required={setting.required} required={setting.required}
/> />
), );
)} })}
</DialogContent> </DialogContent>
<DialogFooter> <DialogFooter>
<Button <Button