rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix missing err handler

Browse Source 
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2025-07-18 16:35:19 +02:00
parent afa5a822aa
commit f8236a0f6c
3 changed files with 41 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
pkg/soagen/generator.go
View File

@@ -26,8 +26,14 @@ func GenerateSOAExcel(data SOAData) ([]byte, error) {
defer f.Close()
sheetName := "State of Applicability"
f.NewSheet(sheetName)
f.DeleteSheet("Sheet1")
_, err := f.NewSheet(sheetName)
if err != nil {
return nil, fmt.Errorf("cannot create sheet: %w", err)
}
if err := f.DeleteSheet("Sheet1"); err != nil {
return nil, fmt.Errorf("cannot delete sheet: %w", err)
}
if err := setupSOAHeader(f, sheetName); err != nil {
return nil, fmt.Errorf("cannot setup Excel header: %w", err)
@@ -183,20 +189,26 @@ func processField(f *excelize.File, sheetName string, row int, value interface{}
col := config.Columns[0]
cellRef := fmt.Sprintf("%s%d", col, row)
f.SetCellValue(sheetName, cellRef, v)
if err := f.SetCellValue(sheetName, cellRef, v); err != nil {
return nil, fmt.Errorf("cannot set cell value: %w", err)
}
textStyleID, err := createCellStyle(f, getTextStyle())
if err != nil {
return nil, fmt.Errorf("cannot create text style: %w", err)
}
f.SetCellStyle(sheetName, cellRef, cellRef, textStyleID)
if err := f.SetCellStyle(sheetName, cellRef, cellRef, textStyleID); err != nil {
return nil, fmt.Errorf("cannot set cell style: %w", err)
}
if isFirstRow {
width := config.DefaultWidth
if len(config.Width) > 0 {
width = config.Width[0]
}
f.SetColWidth(sheetName, col, col, width)
if err := f.SetColWidth(sheetName, col, col, width); err != nil {
return nil, fmt.Errorf("cannot set column width: %w", err)
}
}
if config.HasFilter {
@@ -226,20 +238,26 @@ func processField(f *excelize.File, sheetName string, row int, value interface{}
col := config.Columns[0]
cellRef := fmt.Sprintf("%s%d", col, row)
f.SetCellValue(sheetName, cellRef, joinedValue)
if err := f.SetCellValue(sheetName, cellRef, joinedValue); err != nil {
return nil, fmt.Errorf("cannot set cell value: %w", err)
}
textStyleID, err := createCellStyle(f, getTextStyle())
if err != nil {
return nil, fmt.Errorf("cannot create text style: %w", err)
}
f.SetCellStyle(sheetName, cellRef, cellRef, textStyleID)
if err := f.SetCellStyle(sheetName, cellRef, cellRef, textStyleID); err != nil {
return nil, fmt.Errorf("cannot set cell style: %w", err)
}
if isFirstRow {
width := config.DefaultWidth
if len(config.Width) > 0 {
width = config.Width[0]
}
f.SetColWidth(sheetName, col, col, width)
if err := f.SetColWidth(sheetName, col, col, width); err != nil {
return nil, fmt.Errorf("cannot set column width: %w", err)
}
}
if config.HasFilter {

9
pkg/soagen/header.go
View File

@@ -15,6 +15,7 @@
package soagen
import (
"fmt"
"time"
"github.com/xuri/excelize/v2"
@@ -116,14 +117,18 @@ func applyHeaderLayout(f *excelize.File, sheetName string, layout HeaderLayout,
func applyCells(f *excelize.File, sheetName string, cells []HeaderCell, headerStyle, cellStyle int) error {
for _, cell := range cells {
f.SetCellValue(sheetName, cell.Cell, cell.Value)
if err := f.SetCellValue(sheetName, cell.Cell, cell.Value); err != nil {
return fmt.Errorf("cannot set cell value: %w", err)
}
style := cellStyle
if cell.Style == "header" {
style = headerStyle
}
f.SetCellStyle(sheetName, cell.Cell, cell.Cell, style)
if err := f.SetCellStyle(sheetName, cell.Cell, cell.Cell, style); err != nil {
return fmt.Errorf("cannot set cell style: %w", err)
}
}
return nil
}

10
pkg/soagen/styles.go
View File

@@ -78,12 +78,18 @@ func applyDataValidation(f *excelize.File, sheetName, col string, row int, valid
dv.Sqref = fmt.Sprintf("%s%d:%s1000", col, row, col) // Apply to reasonable range
dv.SetDropList(validation)
dv.SetError(excelize.DataValidationErrorStyleStop, "Invalid Input", "Please select from the dropdown list.")
return f.AddDataValidation(sheetName, dv)
if err := f.AddDataValidation(sheetName, dv); err != nil {
return fmt.Errorf("cannot add data validation: %w", err)
}
return nil
}
func setColumnWidth(f *excelize.File, sheetName, col string, width float64) error {
if width > 0 {
f.SetColWidth(sheetName, col, col, width)
if err := f.SetColWidth(sheetName, col, col, width); err != nil {
return fmt.Errorf("cannot set column width: %w", err)
}
}
return nil
}