Fix n8n ProboTrigger node package review issues
- Log delete failures in deleteSubscription instead of swallowing them - Correct codex node prefix to @probo/n8n-nodes-probo.proboTrigger - Replace unsupported codex categories with Development and Utility Signed-off-by: Sacha Al Himdani <sacha@probo.com>
This commit is contained in:
@@ -1,8 +1,8 @@
|
|||||||
{
|
{
|
||||||
"node": "n8n-nodes-probo.proboTrigger",
|
"node": "@probo/n8n-nodes-probo.proboTrigger",
|
||||||
"nodeVersion": "1.0",
|
"nodeVersion": "1.0",
|
||||||
"codexVersion": "1.0",
|
"codexVersion": "1.0",
|
||||||
"categories": ["Development", "Developer Tools", "Automation"],
|
"categories": ["Development", "Utility"],
|
||||||
"resources": {
|
"resources": {
|
||||||
"credentialDocumentation": [
|
"credentialDocumentation": [
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -60,7 +60,11 @@ async function deleteSubscription(this: IHookFunctions, subscriptionId: string):
|
|||||||
await proboApiRequest.call(this, query, {
|
await proboApiRequest.call(this, query, {
|
||||||
input: { webhookSubscriptionId: subscriptionId },
|
input: { webhookSubscriptionId: subscriptionId },
|
||||||
});
|
});
|
||||||
} catch {
|
} catch (error) {
|
||||||
|
this.logger.error(`Failed to delete Probo webhook subscription "${subscriptionId}"`, {
|
||||||
|
subscriptionId,
|
||||||
|
error,
|
||||||
|
});
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user