From f14d8115b6c02ffe79bc0b40e5672e4990e09037 Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Wed, 15 Jul 2026 17:41:47 +0200 Subject: [PATCH] Fix n8n ProboTrigger node package review issues - Log delete failures in deleteSubscription instead of swallowing them - Correct codex node prefix to @probo/n8n-nodes-probo.proboTrigger - Replace unsupported codex categories with Development and Utility Signed-off-by: Sacha Al Himdani --- packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.json | 4 ++-- packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.ts | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.json b/packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.json index 3dbc9d6d8..08015b9ae 100644 --- a/packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.json +++ b/packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.json @@ -1,8 +1,8 @@ { - "node": "n8n-nodes-probo.proboTrigger", + "node": "@probo/n8n-nodes-probo.proboTrigger", "nodeVersion": "1.0", "codexVersion": "1.0", - "categories": ["Development", "Developer Tools", "Automation"], + "categories": ["Development", "Utility"], "resources": { "credentialDocumentation": [ { diff --git a/packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.ts b/packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.ts index 779e3c498..31aede2e5 100644 --- a/packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.ts +++ b/packages/n8n-node/nodes/ProboTrigger/ProboTrigger.node.ts @@ -60,7 +60,11 @@ async function deleteSubscription(this: IHookFunctions, subscriptionId: string): await proboApiRequest.call(this, query, { input: { webhookSubscriptionId: subscriptionId }, }); - } catch { + } catch (error) { + this.logger.error(`Failed to delete Probo webhook subscription "${subscriptionId}"`, { + subscriptionId, + error, + }); return false; }