Use entity name as CIMD client name

OAuth client_name should be the short brand
label, not the composed English hero heading.

Signed-off-by: Émile Ré <emile@probo.com>

pkg/complianceportal/visitor/cimd.go

@@ -85,7 +85,7 @@ func BuildClientMetadataDocument(
 
 	doc := oauth2.ClientMetadataDocument{
 		ClientID:                clientID,
-		ClientName:              "Compliance at " + portal.EntityName + ".",
+		ClientName:              portal.EntityName,
 		ClientURI:               portalRootURL,
 		RedirectURIs:            []string{redirectURI},
 		TokenEndpointAuthMethod: "none",

pkg/complianceportal/visitor/cimd_test.go

@@ -76,7 +76,7 @@ func TestBuildClientMetadataDocument(t *testing.T) {
 	)
 	require.NoError(t, err)
 	assert.Equal(t, "https://acme.example.com/.well-known/oauth-client-metadata", doc.ClientID)
-	assert.Equal(t, "Compliance at Acme.", doc.ClientName)
+	assert.Equal(t, "Acme", doc.ClientName)
 	assert.Equal(t, []string{"https://acme.example.com/callback"}, doc.RedirectURIs)
 	assert.Equal(t, "https://acme.example.com", doc.ClientURI)
 	assert.Equal(t, VisitorOAuthScope, doc.Scope)