rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Log instance name resolution failures as warning

Browse Source 
Provider 4xx on an instance-name lookup is rarely actionable -- it
usually reflects a configuration state (deleted org, revoked token)
rather than a system error worth paging on. Downgrade Probo's own
log entry to Warn. The kit/worker entry for the same failure is
still Error pending the retry-limit work, which will mark sources
synced after N attempts and stop the duplicate log line.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-05-23 12:10:43 +02:00
committed by Émile Ré
parent 79bc5aa79e
commit e9c4e39ed9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/accessreview/source_name_worker.go
View File

@@ -166,7 +166,7 @@ func (h *sourceNameHandler) Process(ctx context.Context, source coredata.AccessS
instanceName, err := resolver.ResolveInstanceName(resolveCtx)
if err != nil {
h.logger.ErrorCtx(
h.logger.WarnCtx(
ctx,
"cannot resolve instance name",
log.String("source_id", source.ID.String()),