rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix noisy slack queue message error

Browse Source 
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-02-10 09:32:47 +01:00
parent 90da9cd2b7
commit df56ae90e9
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/probo/trust_center_access_service.go
View File

@@ -365,8 +365,7 @@ func (s TrustCenterAccessService) Update(
if shouldUpdateSlackMessage { if shouldUpdateSlackMessage {
if err := s.svc.SlackMessages.QueueSlackNotification(ctx, access.Email, access.TrustCenterID); err != nil { if err := s.svc.SlackMessages.QueueSlackNotification(ctx, access.Email, access.TrustCenterID); err != nil {
var noConnectorErr slack.ErrNoSlackConnector if !errors.Is(err, slack.ErrNoSlackConnector) {
if !errors.Is(err, noConnectorErr) {
return nil, fmt.Errorf("cannot queue slack notification: %w", err) return nil, fmt.Errorf("cannot queue slack notification: %w", err)
} }
} }

10
pkg/slack/slack_message_service.go
View File

@@ -33,11 +33,9 @@ const (
slackMessageDeduplicationWindow = 7 * 24 * time.Hour slackMessageDeduplicationWindow = 7 * 24 * time.Hour
) )
type ErrNoSlackConnector struct{} var (
ErrNoSlackConnector = errors.New("no slack connector found for organization")
func (e ErrNoSlackConnector) Error() string { )
return "no slack connector found for organization"
}
type ( type (
SlackMessageService struct { SlackMessageService struct {
@@ -214,7 +212,7 @@ func (s *SlackMessageService) QueueSlackNotification(
} }
if !hasSlackConnector { if !hasSlackConnector {
return ErrNoSlackConnector{} return ErrNoSlackConnector
} }
documents, reports, files, err := s.loadDocumentsReportsAndFilesFromAccesses(ctx, tx, trustCenterAccess.ID) documents, reports, files, err := s.loadDocumentsReportsAndFilesFromAccesses(ctx, tx, trustCenterAccess.ID)