From df56ae90e914d2d5cf2154a2169706470b783554 Mon Sep 17 00:00:00 2001 From: Bryan Frimin Date: Tue, 10 Feb 2026 09:32:47 +0100 Subject: [PATCH] Fix noisy slack queue message error Signed-off-by: Bryan Frimin --- pkg/probo/trust_center_access_service.go | 3 +-- pkg/slack/slack_message_service.go | 10 ++++------ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/pkg/probo/trust_center_access_service.go b/pkg/probo/trust_center_access_service.go index bfbf1ce5e..ca6f0caf9 100644 --- a/pkg/probo/trust_center_access_service.go +++ b/pkg/probo/trust_center_access_service.go @@ -365,8 +365,7 @@ func (s TrustCenterAccessService) Update( if shouldUpdateSlackMessage { if err := s.svc.SlackMessages.QueueSlackNotification(ctx, access.Email, access.TrustCenterID); err != nil { - var noConnectorErr slack.ErrNoSlackConnector - if !errors.Is(err, noConnectorErr) { + if !errors.Is(err, slack.ErrNoSlackConnector) { return nil, fmt.Errorf("cannot queue slack notification: %w", err) } } diff --git a/pkg/slack/slack_message_service.go b/pkg/slack/slack_message_service.go index 5d37a8646..1a12993ba 100644 --- a/pkg/slack/slack_message_service.go +++ b/pkg/slack/slack_message_service.go @@ -33,11 +33,9 @@ const ( slackMessageDeduplicationWindow = 7 * 24 * time.Hour ) -type ErrNoSlackConnector struct{} - -func (e ErrNoSlackConnector) Error() string { - return "no slack connector found for organization" -} +var ( + ErrNoSlackConnector = errors.New("no slack connector found for organization") +) type ( SlackMessageService struct { @@ -214,7 +212,7 @@ func (s *SlackMessageService) QueueSlackNotification( } if !hasSlackConnector { - return ErrNoSlackConnector{} + return ErrNoSlackConnector } documents, reports, files, err := s.loadDocumentsReportsAndFilesFromAccesses(ctx, tx, trustCenterAccess.ID)