rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove no-changes guard from document version publish

Browse Source 
Allow publishing a document version even when the content and title
are identical to the current published version.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2026-04-03 15:33:41 +02:00
parent 9bbeb6bd22
commit b610a19b84
2 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/probo/document_service.go
View File

@@ -59,9 +59,6 @@ type (
expectedState coredata.DocumentVersionSignatureState expectedState coredata.DocumentVersionSignatureState
} }
ErrDocumentVersionNoChanges struct {
}
ErrDocumentVersionNotDraft struct { ErrDocumentVersionNotDraft struct {
} }
@@ -178,10 +175,6 @@ func (e ErrSignatureNotCancellable) Error() string {
) )
} }
func (e ErrDocumentVersionNoChanges) Error() string {
return "no changes detected"
}
func (e ErrDocumentVersionNotDraft) Error() string { func (e ErrDocumentVersionNotDraft) Error() string {
return "cannot update a published document version" return "cannot update a published document version"
} }
@@ -2269,11 +2262,6 @@ func (s *DocumentService) publishMajorVersionInTx(
return nil, nil, fmt.Errorf("cannot load published version: %w", err) return nil, nil, fmt.Errorf("cannot load published version: %w", err)
} }
if publishedVersion.Content == documentVersion.Content &&
publishedVersion.Title == documentVersion.Title {
return nil, nil, &ErrDocumentVersionNoChanges{}
}
documentVersion.Major = *document.CurrentPublishedMajor + 1 documentVersion.Major = *document.CurrentPublishedMajor + 1
} else { } else {
documentVersion.Major = 1 documentVersion.Major = 1

4
pkg/server/api/console/v1/v1_resolver.go
View File

@@ -5560,10 +5560,6 @@ func (r *mutationResolver) PublishMajorDocumentVersion(ctx context.Context, inpu
return nil, gqlutils.Invalid(ctx, errNotDraft) return nil, gqlutils.Invalid(ctx, errNotDraft)
} }
if errNoChanges, ok := errors.AsType[*probo.ErrDocumentVersionNoChanges](err); ok {
return nil, gqlutils.Invalid(ctx, errNoChanges)
}
r.logger.ErrorCtx(ctx, "cannot publish major document version", log.Error(err)) r.logger.ErrorCtx(ctx, "cannot publish major document version", log.Error(err))
return nil, gqlutils.Internal(ctx) return nil, gqlutils.Internal(ctx)
} }