From b610a19b843dcb7f97b7c28571e3f2c99b268abc Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Fri, 3 Apr 2026 15:33:41 +0200 Subject: [PATCH] Remove no-changes guard from document version publish Allow publishing a document version even when the content and title are identical to the current published version. Signed-off-by: Sacha Al Himdani --- pkg/probo/document_service.go | 12 ------------ pkg/server/api/console/v1/v1_resolver.go | 4 ---- 2 files changed, 16 deletions(-) diff --git a/pkg/probo/document_service.go b/pkg/probo/document_service.go index 091561c1a..c6734f1f4 100644 --- a/pkg/probo/document_service.go +++ b/pkg/probo/document_service.go @@ -59,9 +59,6 @@ type ( expectedState coredata.DocumentVersionSignatureState } - ErrDocumentVersionNoChanges struct { - } - ErrDocumentVersionNotDraft struct { } @@ -178,10 +175,6 @@ func (e ErrSignatureNotCancellable) Error() string { ) } -func (e ErrDocumentVersionNoChanges) Error() string { - return "no changes detected" -} - func (e ErrDocumentVersionNotDraft) Error() string { return "cannot update a published document version" } @@ -2269,11 +2262,6 @@ func (s *DocumentService) publishMajorVersionInTx( return nil, nil, fmt.Errorf("cannot load published version: %w", err) } - if publishedVersion.Content == documentVersion.Content && - publishedVersion.Title == documentVersion.Title { - return nil, nil, &ErrDocumentVersionNoChanges{} - } - documentVersion.Major = *document.CurrentPublishedMajor + 1 } else { documentVersion.Major = 1 diff --git a/pkg/server/api/console/v1/v1_resolver.go b/pkg/server/api/console/v1/v1_resolver.go index 947a39177..ad1525ac1 100644 --- a/pkg/server/api/console/v1/v1_resolver.go +++ b/pkg/server/api/console/v1/v1_resolver.go @@ -5560,10 +5560,6 @@ func (r *mutationResolver) PublishMajorDocumentVersion(ctx context.Context, inpu return nil, gqlutils.Invalid(ctx, errNotDraft) } - if errNoChanges, ok := errors.AsType[*probo.ErrDocumentVersionNoChanges](err); ok { - return nil, gqlutils.Invalid(ctx, errNoChanges) - } - r.logger.ErrorCtx(ctx, "cannot publish major document version", log.Error(err)) return nil, gqlutils.Internal(ctx) }