rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Block delete for in-progress access review campaigns

Browse Source 
Reject deletion while a campaign is fetching sources so workers are
not racing a removed record. All other statuses remain deletable.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-07-29 15:48:41 +00:00
parent b156b0333a
commit b229da0115
6 changed files with 45 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/console/src/pages/organizations/access-reviews/campaigns/AccessReviewCampaignsTab.tsx
View File

@@ -132,6 +132,8 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
deleteCampaignMutation,
);
const isDeletableStatus = (status: string) => status !== "IN_PROGRESS";
const handleDelete = (campaignId: string, campaignName: string) => {
confirm(
() => {
@@ -178,7 +180,9 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
);
};
const hasActions = accessReviewCampaigns.edges.some(edge => edge.node.canDelete);
const hasActions = accessReviewCampaigns.edges.some(
edge => edge.node.canDelete && isDeletableStatus(edge.node.status),
);
return (
<div className="space-y-4">
@@ -209,7 +213,8 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
</Thead>
<Tbody>
{accessReviewCampaigns.edges.map((edge) => {
const canDeleteRow = edge.node.canDelete;
const canDeleteRow
= edge.node.canDelete && isDeletableStatus(edge.node.status);
return (
<Tr
key={edge.node.id}

2
apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
View File

@@ -216,7 +216,7 @@ export default function CampaignDetailPage({ queryRef }: Props) {
const isInProgress = campaign.status === "IN_PROGRESS";
const isDraft = campaign.status === "DRAFT";
const isPendingActions = campaign.status === "PENDING_ACTIONS";
const canDelete = campaign.canDelete;
const canDelete = campaign.canDelete && !isInProgress;
const campaignIdRef = useRef(campaign.id);