From b229da0115cb629d5047910fb896c7320f5324dc Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Wed, 29 Jul 2026 15:48:41 +0000
Subject: [PATCH] Block delete for in-progress access review campaigns

Reject deletion while a campaign is fetching sources so workers are
not racing a removed record. All other statuses remain deletable.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
---
 .../campaigns/AccessReviewCampaignsTab.tsx    |  9 +++++++--
 .../campaigns/CampaignDetailPage.tsx          |  2 +-
 pkg/accessreview/campaign_service.go          |  4 ++++
 pkg/accessreview/errors.go                    | 20 +++++++++++++++++++
 pkg/accessreview/errors_test.go               |  9 +++++++++
 .../v1/access_review_campaign_resolvers.go    |  4 ++++
 6 files changed, 45 insertions(+), 3 deletions(-)

diff --git a/apps/console/src/pages/organizations/access-reviews/campaigns/AccessReviewCampaignsTab.tsx b/apps/console/src/pages/organizations/access-reviews/campaigns/AccessReviewCampaignsTab.tsx
index d25852045..f36b8bf00 100644
--- a/apps/console/src/pages/organizations/access-reviews/campaigns/AccessReviewCampaignsTab.tsx
+++ b/apps/console/src/pages/organizations/access-reviews/campaigns/AccessReviewCampaignsTab.tsx
@@ -132,6 +132,8 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
     deleteCampaignMutation,
   );
 
+  const isDeletableStatus = (status: string) => status !== "IN_PROGRESS";
+
   const handleDelete = (campaignId: string, campaignName: string) => {
     confirm(
       () => {
@@ -178,7 +180,9 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
     );
   };
 
-  const hasActions = accessReviewCampaigns.edges.some(edge => edge.node.canDelete);
+  const hasActions = accessReviewCampaigns.edges.some(
+    edge => edge.node.canDelete && isDeletableStatus(edge.node.status),
+  );
 
   return (
     <div className="space-y-4">
@@ -209,7 +213,8 @@ export default function AccessReviewCampaignsTab({ queryRef }: Props) {
                 </Thead>
                 <Tbody>
                   {accessReviewCampaigns.edges.map((edge) => {
-                    const canDeleteRow = edge.node.canDelete;
+                    const canDeleteRow
+                      = edge.node.canDelete && isDeletableStatus(edge.node.status);
                     return (
                       <Tr
                         key={edge.node.id}
diff --git a/apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx b/apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
index 9dd45ced3..1a204763a 100644
--- a/apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
+++ b/apps/console/src/pages/organizations/access-reviews/campaigns/CampaignDetailPage.tsx
@@ -216,7 +216,7 @@ export default function CampaignDetailPage({ queryRef }: Props) {
   const isInProgress = campaign.status === "IN_PROGRESS";
   const isDraft = campaign.status === "DRAFT";
   const isPendingActions = campaign.status === "PENDING_ACTIONS";
-  const canDelete = campaign.canDelete;
+  const canDelete = campaign.canDelete && !isInProgress;
 
   const campaignIdRef = useRef(campaign.id);
 
diff --git a/pkg/accessreview/campaign_service.go b/pkg/accessreview/campaign_service.go
index a8ec37d25..7885a8ad4 100644
--- a/pkg/accessreview/campaign_service.go
+++ b/pkg/accessreview/campaign_service.go
@@ -205,6 +205,10 @@ func (s *Service) DeleteCampaign(
 				return fmt.Errorf("cannot load campaign: %w", err)
 			}
 
+			if campaign.Status == coredata.AccessReviewCampaignStatusInProgress {
+				return NewCampaignNotDeletableError(campaign.ID)
+			}
+
 			if err := campaign.Delete(ctx, conn, scope); err != nil {
 				return fmt.Errorf("cannot delete campaign: %w", err)
 			}
diff --git a/pkg/accessreview/errors.go b/pkg/accessreview/errors.go
index 5fd6ce16a..cdb40683b 100644
--- a/pkg/accessreview/errors.go
+++ b/pkg/accessreview/errors.go
@@ -30,6 +30,7 @@ import (
 var (
 	ErrCampaignMissingSources    = errors.New("access review campaign missing scope sources")
 	ErrCampaignNotDraft          = errors.New("access review campaign not draft")
+	ErrCampaignNotDeletable      = errors.New("access review campaign not deletable")
 	ErrCampaignNotPendingActions = errors.New("access review campaign not pending actions")
 	ErrCampaignCompleted         = errors.New("access review campaign completed")
 	ErrCampaignCancelled         = errors.New("access review campaign cancelled")
@@ -44,6 +45,10 @@ type (
 		CampaignID gid.GID
 	}
 
+	CampaignNotDeletableError struct {
+		CampaignID gid.GID
+	}
+
 	CampaignNotPendingActionsError struct {
 		CampaignID gid.GID
 	}
@@ -84,6 +89,21 @@ func (e *CampaignNotDraftError) Is(target error) bool {
 	return target == ErrCampaignNotDraft
 }
 
+func NewCampaignNotDeletableError(campaignID gid.GID) error {
+	return &CampaignNotDeletableError{CampaignID: campaignID}
+}
+
+func (e *CampaignNotDeletableError) Error() string {
+	return fmt.Sprintf(
+		"access review campaign %q cannot be deleted while it is in progress",
+		e.CampaignID,
+	)
+}
+
+func (e *CampaignNotDeletableError) Is(target error) bool {
+	return target == ErrCampaignNotDeletable
+}
+
 func NewCampaignNotPendingActionsError(campaignID gid.GID) error {
 	return &CampaignNotPendingActionsError{CampaignID: campaignID}
 }
diff --git a/pkg/accessreview/errors_test.go b/pkg/accessreview/errors_test.go
index 51b562884..b26d541de 100644
--- a/pkg/accessreview/errors_test.go
+++ b/pkg/accessreview/errors_test.go
@@ -57,6 +57,15 @@ func TestCampaignClientErrors(t *testing.T) {
 			wantText: fmt.Sprintf("access review campaign %q is not in draft", campaignID),
 			sentinel: accessreview.ErrCampaignNotDraft,
 		},
+		{
+			name: "not deletable",
+			err:  accessreview.NewCampaignNotDeletableError(campaignID),
+			wantText: fmt.Sprintf(
+				"access review campaign %q cannot be deleted while it is in progress",
+				campaignID,
+			),
+			sentinel: accessreview.ErrCampaignNotDeletable,
+		},
 		{
 			name: "not pending actions",
 			err:  accessreview.NewCampaignNotPendingActionsError(campaignID),
diff --git a/pkg/server/api/console/v1/access_review_campaign_resolvers.go b/pkg/server/api/console/v1/access_review_campaign_resolvers.go
index ca25b67c6..84059aa52 100644
--- a/pkg/server/api/console/v1/access_review_campaign_resolvers.go
+++ b/pkg/server/api/console/v1/access_review_campaign_resolvers.go
@@ -787,6 +787,10 @@ func (r *mutationResolver) DeleteAccessReviewCampaign(ctx context.Context, input
 			return nil, gqlutils.NotFound(ctx, err)
 		}
 
+		if errors.Is(err, accessreview.ErrCampaignNotDeletable) {
+			return nil, gqlutils.Invalid(ctx, err)
+		}
+
 		r.logger.ErrorCtx(ctx, "cannot delete access review campaign", log.Error(err))
 
 		return nil, gqlutils.Internal(ctx)