rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Document Cloudflare per_page floor and Vercel teamId

Browse Source 
Note that Cloudflare requires per_page in 5..50 so nobody optimizes
it back to per_page=1, which returned 400 and, before terminal
classification, produced a 400 storm. Also correct a stale team_id
reference in the Vercel user-fetch comment: the OAuth callback
surfaces the team as teamId.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-07-22 14:49:26 +02:00
parent d18127503d
commit a7bcbbcd85
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/accessreview/drivers/name_resolver.go
View File

@@ -206,6 +206,9 @@ func (r *cloudflareNameResolver) ResolveInstanceName(ctx context.Context) (strin
q := cfURL.Query()
q.Set("page", "1")
// Cloudflare requires per_page in the range 5..50; per_page=1 is rejected
// with a 400 (which, before terminal classification, caused a 400 storm).
// Do not "optimize" this back down to 1.
q.Set("per_page", "50")
cfURL.RawQuery = q.Encode()