rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Give unlink full parity with first-party cleanup

Browse Source 
Unlinking previously cleared only the catalog vendor link, leaving the
stale description that still named the removed vendor and leaving the
linked org tracker patterns pointing at it. Because the verdict becomes
UNDETERMINED the pipeline is meant to re-probe the row, so the stale
state was misleading until that happened.

Clear the description on both the catalog row and its uncategorised org
tracker patterns, and remap those org patterns so they drop the stale
vendor and re-resolve. A re-resolved vendor re-arms catalog enrichment
via the blank-and-unlinked upsert path, re-deriving the description.
This mirrors the cleanup mark-first-party already performs, minus the
terminal verdict.

Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
Émile Ré
2026-06-18 19:50:33 +02:00
parent 265c56d00b
commit a2d3852fea
1 changed files with 41 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
pkg/proboctl/commontrackerpattern/unlink.go
View File

@@ -41,10 +41,15 @@ func newCmdUnlink(f *cmdutil.Factory) *cobra.Command {
cmd := &cobra.Command{
Use: "unlink",
Short: "Unlink common tracker patterns from any common third party",
Long: "Detach selected common tracker patterns from their common third party. " +
"Unlinking only clears the catalog link: there is no new vendor to " +
"re-enrich a description for or to remap org patterns onto, so neither " +
"enrichment nor org remapping is triggered. Selection mirrors 'reenrich'.",
Long: "Detach selected common tracker patterns from their common third party, " +
"returning the verdict to UNDETERMINED so the pipeline can re-probe them. " +
"The now-stale description - which still names the removed vendor - is " +
"blanked on both the catalog row and the uncategorised org tracker patterns " +
"linked to it, and those org patterns are remapped (org third party cleared, " +
"mapping re-armed) so the pipeline drops the stale vendor and re-resolves; a " +
"re-resolved vendor re-arms catalog enrichment, re-deriving the description. " +
"User-categorised and excluded org patterns are left untouched. Selection " +
"mirrors 'reenrich'.",
Args: cobra.NoArgs,
}
@@ -101,7 +106,11 @@ func newCmdUnlink(f *cmdutil.Factory) *cobra.Command {
return fmt.Errorf("about to unlink %d pattern(s); pass --yes to proceed or --dry-run to preview", len(ids))
}
var unlinked int64
var (
unlinked int64
remapped int64
cleared int64
)
if err := pgClient.WithTx(
ctx,
@@ -109,14 +118,39 @@ func newCmdUnlink(f *cmdutil.Factory) *cobra.Command {
var ps coredata.CommonTrackerPatterns
unlinked, err = ps.RelinkCommonThirdPartyByIDs(ctx, tx, ids, nil)
if err != nil {
return err
}
return err
if _, err = ps.ClearDescriptionByIDs(ctx, tx, ids); err != nil {
return err
}
var tps coredata.TrackerPatterns
remapped, err = tps.RequestMappingForUncategorisedByCommonTrackerPatternIDs(ctx, tx, ids)
if err != nil {
return err
}
cleared, err = tps.ClearDescriptionForUncategorisedByCommonTrackerPatternIDs(ctx, tx, ids)
if err != nil {
return err
}
return nil
},
); err != nil {
return fmt.Errorf("cannot unlink common tracker patterns: %w", err)
}
_, _ = fmt.Fprintf(out, "Unlinked %d pattern(s) from any common third party.\n", unlinked)
_, _ = fmt.Fprintf(
out,
"Unlinked %d pattern(s) from any common third party, remapped %d uncategorised org tracker pattern(s), cleared %d stale org description(s).\n",
unlinked,
remapped,
cleared,
)
return nil
}