Trim access-review connector comments

Cut verbose inline comments across the access-review connector changes:
the mechanical fact stays at the read site, while incident backstory
("millions of error logs in prod") and provider-specific rationale (why
Clerk reviews the wrong population) move to the commit history where they
belong. Also tighten a loose "a 4xx" to "an auth/not-found 4xx" so the
terminal-classification contract is not overstated. No behavior change.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-07-22 17:19:08 +02:00
parent a7bcbbcd85
commit a0ead155db
7 changed files with 28 additions and 53 deletions

View File

@@ -360,11 +360,8 @@ WHERE
}
// ClearNameSyncedAtByConnectorID resets name_synced_at to NULL for every
// access source backed by connectorID so the source-name worker re-resolves
// the display name. A reconnect (possibly with a new scope/org) or a manual
// org (re)configuration can change the resolvable instance name; without this
// a source that was terminal-marked keeps its generic name forever. It is a
// no-op when no source references the connector.
// access source backed by connectorID, so the source-name worker re-resolves
// their display name. No-op when no source references the connector.
func (sources *AccessReviewSources) ClearNameSyncedAtByConnectorID(
ctx context.Context,
conn pg.Tx,