rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Trim access-review connector comments

Browse Source 
Cut verbose inline comments across the access-review connector changes:
the mechanical fact stays at the read site, while incident backstory
("millions of error logs in prod") and provider-specific rationale (why
Clerk reviews the wrong population) move to the commit history where they
belong. Also tighten a loose "a 4xx" to "an auth/not-found 4xx" so the
terminal-classification contract is not overstated. No behavior change.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-07-22 17:19:08 +02:00
parent a7bcbbcd85
commit a0ead155db
7 changed files with 28 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/coredata/access_review_source.go
View File

@@ -360,11 +360,8 @@ WHERE
}
// ClearNameSyncedAtByConnectorID resets name_synced_at to NULL for every
// access source backed by connectorID so the source-name worker re-resolves
// the display name. A reconnect (possibly with a new scope/org) or a manual
// org (re)configuration can change the resolvable instance name; without this
// a source that was terminal-marked keeps its generic name forever. It is a
// no-op when no source references the connector.
// access source backed by connectorID, so the source-name worker re-resolves
// their display name. No-op when no source references the connector.
func (sources *AccessReviewSources) ClearNameSyncedAtByConnectorID(
ctx context.Context,
conn pg.Tx,

10
pkg/coredata/connector_provider.go
View File

@@ -58,14 +58,8 @@ const (
ConnectorProviderAsana ConnectorProvider = "ASANA"
ConnectorProviderNetlify ConnectorProvider = "NETLIFY"
ConnectorProviderClickUp ConnectorProvider = "CLICKUP"
// ConnectorProviderClerk is retained for existing connectors but is
// no longer a registerable access-review provider: Clerk's Backend API
// (secret key) only exposes the customer's application end-users, not
// the Clerk workspace/dashboard team who administer the platform, so a
// campaign reviews the wrong population. Kept in IsValid and the
// GraphQL enum so stored CLERK rows still validate and serialize;
// dropped from ConnectorProviders and unregistered from the builtin
// registry so it cannot be added or fetched.
// ConnectorProviderClerk is disabled (unregistered) but kept in IsValid
// and the GraphQL enum so existing stored CLERK rows still validate.
ConnectorProviderClerk ConnectorProvider = "CLERK"
ConnectorProviderVercel ConnectorProvider = "VERCEL"
ConnectorProviderMonday ConnectorProvider = "MONDAY"