rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Trim access-review connector comments

Browse Source 
Cut verbose inline comments across the access-review connector changes:
the mechanical fact stays at the read site, while incident backstory
("millions of error logs in prod") and provider-specific rationale (why
Clerk reviews the wrong population) move to the commit history where they
belong. Also tighten a loose "a 4xx" to "an auth/not-found 4xx" so the
terminal-classification contract is not overstated. No behavior change.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-07-22 17:19:08 +02:00
parent a7bcbbcd85
commit a0ead155db
7 changed files with 28 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/accessreview/source_service.go
View File

@@ -582,18 +582,14 @@ func (s *Service) SourceNeedsConfiguration(
return cfg.SelectedSlug(dbConnector) == "", nil
}
// AutoSelectDefaultOrganization picks the first workspace/org the connector
// can see for a freshly linked picker-provider source that has none selected
// yet. Without it a connected source stays "needs configuration" until the
// user completes the picker; if they skip it, the first campaign silently
// resolves no users (the driver requires an org). Defaulting to the first
// available makes the source immediately usable; the picker stays available
// to switch when several are listed.
// AutoSelectDefaultOrganization picks the first workspace/org a freshly linked
// picker-provider source can see when none is selected yet, so the source is
// usable immediately instead of failing its first campaign fetch. The picker
// stays available to switch when several are listed.
//
// Best-effort: any failure (provider unreachable, nothing listed) leaves the
// source in its existing "needs configuration" state, where the picker is the
// fallback. It never returns an error and must not fail the create/update
// that triggered it.
// Best-effort: any failure leaves the source in its "needs configuration"
// state (the picker is the fallback); it never errors and must not fail the
// create/update that triggered it.
func (s *Service) AutoSelectDefaultOrganization(
ctx context.Context,
scope coredata.Scoper,