Fix frontend lint warnings in documents and references
- Remove unused `rank` field from CompliancePageReferenceListItemFragment; the parent list fragment already fetches it for drag-and-drop reordering. Thread `rank` through the onEdit call chain so the edit dialog can still pre-populate the field via a dedicated parameter instead of the fragment. - Add missing `documentTypeFilter` dependency to the refetch useEffect in DocumentList so stale closure values are never used on tab change. - Break overlong line in DocumentList (canSendAnySignatureNotifications). Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
@@ -31,7 +31,7 @@ type ReferenceFormData = z.infer<typeof referenceSchema>;
|
||||
|
||||
export type TrustCenterReferenceDialogRef = {
|
||||
openCreate: (trustCenterId: string, connectionId: string) => void;
|
||||
openEdit: (reference: CompliancePageReferenceListItemFragment$data) => void;
|
||||
openEdit: (reference: CompliancePageReferenceListItemFragment$data, rank: number) => void;
|
||||
};
|
||||
|
||||
export const TrustCenterReferenceDialog = forwardRef<TrustCenterReferenceDialogRef, { children?: ReactNode }>(
|
||||
@@ -72,7 +72,7 @@ export const TrustCenterReferenceDialog = forwardRef<TrustCenterReferenceDialogR
|
||||
});
|
||||
dialogRef.current?.open();
|
||||
},
|
||||
openEdit: (reference: CompliancePageReferenceListItemFragment$data) => {
|
||||
openEdit: (reference: CompliancePageReferenceListItemFragment$data, rank: number) => {
|
||||
setMode("edit");
|
||||
setEditReference(reference);
|
||||
setUploadedFile(null);
|
||||
@@ -80,7 +80,7 @@ export const TrustCenterReferenceDialog = forwardRef<TrustCenterReferenceDialogR
|
||||
name: reference.name,
|
||||
description: reference.description ?? undefined,
|
||||
websiteUrl: reference.websiteUrl,
|
||||
rank: reference.rank,
|
||||
rank,
|
||||
});
|
||||
dialogRef.current?.open();
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user