From 93c3b70ecc10d15ab2759972249a8d73435ab692 Mon Sep 17 00:00:00 2001 From: Sacha Al Himdani Date: Wed, 25 Mar 2026 16:53:58 +0100 Subject: [PATCH] Fix frontend lint warnings in documents and references - Remove unused `rank` field from CompliancePageReferenceListItemFragment; the parent list fragment already fetches it for drag-and-drop reordering. Thread `rank` through the onEdit call chain so the edit dialog can still pre-populate the field via a dedicated parameter instead of the fragment. - Add missing `documentTypeFilter` dependency to the refetch useEffect in DocumentList so stale closure values are never used on tab change. - Break overlong line in DocumentList (canSendAnySignatureNotifications). Signed-off-by: Sacha Al Himdani --- .../TrustCenterReferenceDialog.tsx | 6 ++--- .../CompliancePageReferencesPage.tsx | 4 ++-- .../CompliancePageReferenceList.tsx | 4 ++-- .../CompliancePageReferenceListItem.tsx | 1 - .../documents/_components/DocumentList.tsx | 22 +++++++++---------- 5 files changed, 17 insertions(+), 20 deletions(-) diff --git a/apps/console/src/components/trustCenter/TrustCenterReferenceDialog.tsx b/apps/console/src/components/trustCenter/TrustCenterReferenceDialog.tsx index edc6f242f..104abc9e1 100644 --- a/apps/console/src/components/trustCenter/TrustCenterReferenceDialog.tsx +++ b/apps/console/src/components/trustCenter/TrustCenterReferenceDialog.tsx @@ -31,7 +31,7 @@ type ReferenceFormData = z.infer; export type TrustCenterReferenceDialogRef = { openCreate: (trustCenterId: string, connectionId: string) => void; - openEdit: (reference: CompliancePageReferenceListItemFragment$data) => void; + openEdit: (reference: CompliancePageReferenceListItemFragment$data, rank: number) => void; }; export const TrustCenterReferenceDialog = forwardRef( @@ -72,7 +72,7 @@ export const TrustCenterReferenceDialog = forwardRef { + openEdit: (reference: CompliancePageReferenceListItemFragment$data, rank: number) => { setMode("edit"); setEditReference(reference); setUploadedFile(null); @@ -80,7 +80,7 @@ export const TrustCenterReferenceDialog = forwardRef { - dialogRef.current?.openEdit(reference); + const handleEdit = (reference: CompliancePageReferenceListItemFragment$data, rank: number) => { + dialogRef.current?.openEdit(reference, rank); }; return ( diff --git a/apps/console/src/pages/organizations/compliance-page/references/_components/CompliancePageReferenceList.tsx b/apps/console/src/pages/organizations/compliance-page/references/_components/CompliancePageReferenceList.tsx index 32906c67d..530e16d3a 100644 --- a/apps/console/src/pages/organizations/compliance-page/references/_components/CompliancePageReferenceList.tsx +++ b/apps/console/src/pages/organizations/compliance-page/references/_components/CompliancePageReferenceList.tsx @@ -35,7 +35,7 @@ const fragment = graphql` export function CompliancePageReferenceList(props: { fragmentRef: CompliancePageReferenceListFragment$key; - onEdit: (r: CompliancePageReferenceListItemFragment$data) => void; + onEdit: (r: CompliancePageReferenceListItemFragment$data, rank: number) => void; }) { const { fragmentRef, onEdit } = props; @@ -116,7 +116,7 @@ export function CompliancePageReferenceList(props: { index={index} isDragging={draggedIndex === index} isDropTarget={dragOverIndex === index && draggedIndex !== index} - onEdit={(r: CompliancePageReferenceListItemFragment$data) => onEdit(r)} + onEdit={(r: CompliancePageReferenceListItemFragment$data) => onEdit(r, reference.rank)} connectionId={references.__id} onDragStart={() => handleDragStart(index)} onDragOver={e => handleDragOver(e, index)} diff --git a/apps/console/src/pages/organizations/compliance-page/references/_components/CompliancePageReferenceListItem.tsx b/apps/console/src/pages/organizations/compliance-page/references/_components/CompliancePageReferenceListItem.tsx index 4f9fb6507..19b764c32 100644 --- a/apps/console/src/pages/organizations/compliance-page/references/_components/CompliancePageReferenceListItem.tsx +++ b/apps/console/src/pages/organizations/compliance-page/references/_components/CompliancePageReferenceListItem.tsx @@ -14,7 +14,6 @@ const fragment = graphql` name description websiteUrl - rank canUpdate: permission(action: "core:trust-center-reference:update") canDelete: permission(action: "core:trust-center-reference:delete") } diff --git a/apps/console/src/pages/organizations/documents/_components/DocumentList.tsx b/apps/console/src/pages/organizations/documents/_components/DocumentList.tsx index a0137ea5a..134f00c3a 100644 --- a/apps/console/src/pages/organizations/documents/_components/DocumentList.tsx +++ b/apps/console/src/pages/organizations/documents/_components/DocumentList.tsx @@ -118,11 +118,13 @@ export function DocumentList(props: { const refetch = pagination.refetch; useEffect(() => { - refetch( - { status: [tab], documentTypes: documentTypeFilter ? [documentTypeFilter] : null }, - { fetchPolicy: "store-and-network" }, - ); - }, [tab, refetch]); + startTransition(() => { + refetch( + { status: [tab], documentTypes: documentTypeFilter ? [documentTypeFilter] : null }, + { fetchPolicy: "store-and-network" }, + ); + }); + }, [tab, refetch, documentTypeFilter]); const documents = pagination.data.documents.edges.map(({ node }) => node); const connectionId = pagination.data.documents.__id; @@ -145,7 +147,9 @@ export function DocumentList(props: { const canRequestAnySignatures = documents.some(({ canRequestSignatures }) => canRequestSignatures); const canArchiveAny = documents.some(({ canArchive }) => canArchive); const canUnarchiveAny = documents.some(({ canUnarchive }) => canUnarchive); - const canSendAnySignatureNotifications = documents.some(({ canSendSigningNotifications }) => canSendSigningNotifications); + const canSendAnySignatureNotifications = documents.some( + ({ canSendSigningNotifications }) => canSendSigningNotifications, + ); const hasAnyAction = tab === "ARCHIVED" ? canUnarchiveAny || canDeleteAny : canDeleteAny || canUpdateAny; useEffect(() => { @@ -170,12 +174,6 @@ export function DocumentList(props: { }, ), ); - startTransition(() => { - pagination.refetch( - { status: [tab], documentTypes: newType ? [newType] : null }, - { fetchPolicy: "store-and-network" }, - ); - }); }; const handleBulkDelete = () => {