rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Handle LoadByID errors explicitly instead of silently falling through to auto-create

Browse Source 
Signed-off-by: Émile Ré <emile@probo.com>
This commit is contained in:
Émile Ré
2026-05-14 17:16:32 +04:00
parent 0866276074
commit 844817543d
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/common-tracker-patterns-import/main.go
View File

@@ -310,7 +310,10 @@ func resolveThirdParty(
if !errors.Is(err, coredata.ErrResourceNotFound) { if !errors.Is(err, coredata.ErrResourceNotFound) {
return nil, fmt.Errorf("cannot look up common third party by domain %q: %w", domain, err) return nil, fmt.Errorf("cannot look up common third party by domain %q: %w", domain, err)
} }
} else if err := party.LoadByID(ctx, tx, domainRow.CommonThirdPartyID); err == nil { } else {
if err := party.LoadByID(ctx, tx, domainRow.CommonThirdPartyID); err != nil {
return nil, fmt.Errorf("cannot load common third party by ID %s: %w", domainRow.CommonThirdPartyID, err)
}
cache[platformSlug] = &party.ID cache[platformSlug] = &party.ID
return &party.ID, nil return &party.ID, nil
} }