From 844817543df4f82bac4798045dd1a0b785b94876 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89mile=20R=C3=A9?= Date: Thu, 14 May 2026 17:16:32 +0400 Subject: [PATCH] Handle LoadByID errors explicitly instead of silently falling through to auto-create MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Émile Ré --- cmd/common-tracker-patterns-import/main.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmd/common-tracker-patterns-import/main.go b/cmd/common-tracker-patterns-import/main.go index 52775a609..adba5f148 100644 --- a/cmd/common-tracker-patterns-import/main.go +++ b/cmd/common-tracker-patterns-import/main.go @@ -310,7 +310,10 @@ func resolveThirdParty( if !errors.Is(err, coredata.ErrResourceNotFound) { return nil, fmt.Errorf("cannot look up common third party by domain %q: %w", domain, err) } - } else if err := party.LoadByID(ctx, tx, domainRow.CommonThirdPartyID); err == nil { + } else { + if err := party.LoadByID(ctx, tx, domainRow.CommonThirdPartyID); err != nil { + return nil, fmt.Errorf("cannot load common third party by ID %s: %w", domainRow.CommonThirdPartyID, err) + } cache[platformSlug] = &party.ID return &party.ID, nil }