Use inline trufflehog:ignore instead of exclude paths file
Inline comments are more targeted than excluding the entire file from secret scanning. Remove the .trufflehog.yml exclude file and the --exclude-paths flag from the workflow. Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
committed by
Sacha Al Himdani
parent
bba7855678
commit
7dcc3d21ac
2
.github/workflows/secrets.yaml
vendored
2
.github/workflows/secrets.yaml
vendored
@@ -19,4 +19,4 @@ jobs:
|
||||
submodules: recursive
|
||||
- uses: "trufflesecurity/trufflehog@b78fbfd8eb982f4802e09a265fb2bc37b3040975" # main
|
||||
with:
|
||||
extra_args: "--results=verified,unknown --exclude-paths=.trufflehog.yml"
|
||||
extra_args: "--results=verified,unknown"
|
||||
|
||||
@@ -1 +0,0 @@
|
||||
pkg/agent/guardrail/sensitive_data_test\.go
|
||||
@@ -82,12 +82,12 @@ func TestSensitiveDataGuardrail_Check(t *testing.T) {
|
||||
{"pem certificate", "-----BEGIN CERTIFICATE-----\nMIIE...", true},
|
||||
|
||||
// Connection strings
|
||||
{"postgres uri", "Connect to postgres://user:pass@host/db", true},
|
||||
{"postgresql uri", "Connect to postgresql://user:pass@host/db", true},
|
||||
{"mongodb uri", "Use mongodb://user:pass@host/db", true},
|
||||
{"postgres uri", "Connect to postgres://user:pass@host/db", true}, // trufflehog:ignore
|
||||
{"postgresql uri", "Connect to postgresql://user:pass@host/db", true}, // trufflehog:ignore
|
||||
{"mongodb uri", "Use mongodb://user:pass@host/db", true}, // trufflehog:ignore
|
||||
{"mysql uri", "Use mysql://user:pass@host/db", true},
|
||||
{"redis uri", "Cache at redis://localhost:6379", true},
|
||||
{"amqp uri", "Queue at amqp://guest:guest@host/vhost", true},
|
||||
{"amqp uri", "Queue at amqp://guest:guest@host/vhost", true}, // trufflehog:ignore
|
||||
|
||||
// Generic secret field names
|
||||
{"encryption_key", "The encryption_key is set in config", true},
|
||||
|
||||
Reference in New Issue
Block a user