Harden LoadByIDs func

Signed-off-by: Bryan Frimin <bryan@probo.com>

pkg/coredata/control.go

@@ -790,6 +790,10 @@ WHERE
 
 	*c = controls
 
+	if len(controls) != len(gid.NewSet(controlIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/cookie_banner.go

@@ -314,6 +314,10 @@ WHERE
 
 	*b = banners
 
+	if len(banners) != len(gid.NewSet(bannerIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/cookie_category.go

@@ -296,6 +296,10 @@ WHERE
 
 	*c = categories
 
+	if len(categories) != len(gid.NewSet(categoryIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/document.go

@@ -277,6 +277,10 @@ WHERE
 
 	*p = documents
 
+	if len(documents) != len(gid.NewSet(documentIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/document_version.go

@@ -201,6 +201,10 @@ WHERE
 
 	*dv = documentVersions
 
+	if len(documentVersions) != len(gid.NewSet(documentVersionIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/document_version_approval_quorum.go

@@ -173,6 +173,10 @@ WHERE
 
 	*q = quorums
 
+	if len(quorums) != len(gid.NewSet(quorumIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/file.go

@@ -185,6 +185,10 @@ WHERE
 
 	*f = files
 
+	if len(files) != len(gid.NewSet(fileIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/framework.go

@@ -133,22 +133,6 @@ WHERE
 	return count, nil
 }
 
-func uniqueGIDs(values []gid.GID) []gid.GID {
-	set := make(map[gid.GID]struct{}, len(values))
-	unique := make([]gid.GID, 0, len(values))
-
-	for _, value := range values {
-		if _, ok := set[value]; ok {
-			continue
-		}
-
-		set[value] = struct{}{}
-		unique = append(unique, value)
-	}
-
-	return unique
-}
-
 func (f *Frameworks) LoadByOrganizationID(
 	ctx context.Context,
 	conn pg.Querier,
@@ -334,6 +318,10 @@ WHERE
 
 	*f = frameworks
 
+	if len(frameworks) != len(gid.NewSet(frameworkIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/measure.go

@@ -527,6 +527,10 @@ WHERE
 
 	*m = measures
 
+	if len(measures) != len(gid.NewSet(measureIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/membership_profile.go

@@ -449,6 +449,10 @@ WHERE
 
 	*p = profiles
 
+	if len(profiles) != len(gid.NewSet(profileIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/organization.go

@@ -194,6 +194,10 @@ WHERE
 
 	*o = organizations
 
+	if len(organizations) != len(gid.NewSet(organizationIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/processing_activities.go

@@ -373,6 +373,10 @@ WHERE
 
 	*p = processingActivities
 
+	if len(processingActivities) != len(gid.NewSet(processingActivityIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/risk.go

@@ -564,6 +564,10 @@ WHERE %s
 
 	*r = risks
 
+	if len(risks) != len(gid.NewSet(riskIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/task.go

@@ -205,6 +205,10 @@ WHERE
 
 	*t = tasks
 
+	if len(tasks) != len(gid.NewSet(taskIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/third_party.go

@@ -599,6 +599,10 @@ WHERE
 
 	*v = thirdParties
 
+	if len(thirdParties) != len(gid.NewSet(thirdPartyIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }
 

pkg/coredata/trust_center_file.go

@@ -178,6 +178,10 @@ WHERE
 
 	*f = files
 
+	if len(files) != len(gid.NewSet(trustCenterFileIDs...)) {
+		return ErrResourceNotFound
+	}
+
 	return nil
 }