Review fixes

Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
Émile Ré
2026-05-07 11:52:00 +04:00
parent 9e21f8fb08
commit 72fa79629f
12 changed files with 71 additions and 12 deletions

View File

@@ -20,6 +20,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
@@ -79,7 +80,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -22,6 +22,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
"strings"
@@ -416,7 +417,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -22,6 +22,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
"strings"
@@ -415,7 +416,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -21,6 +21,7 @@ import (
"encoding/json"
"flag"
"fmt"
"net"
"net/url"
"os"
"time"
@@ -130,7 +131,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -22,6 +22,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
"time"
@@ -469,7 +470,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -22,6 +22,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
"time"
@@ -432,7 +433,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -24,6 +24,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
"strings"
@@ -740,7 +741,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -22,6 +22,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
"time"
@@ -507,7 +508,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -22,6 +22,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
"time"
@@ -516,7 +517,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -22,6 +22,7 @@ import (
"context"
"flag"
"fmt"
"net"
"net/url"
"os"
"strings"
@@ -731,7 +732,11 @@ func newPgClientFromDSN(dsn string) (*pg.Client, error) {
var opts []pg.Option
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {

View File

@@ -38,7 +38,11 @@ export class ProboBanner extends ProboElement {
if (this.root) {
this.root.addEventListener("probo-state", this.onStateChange);
this.root.addEventListener("probo-ready", this.onReady, { once: true });
try {
this.validate(this.root.bannerConfig);
} catch {
this.root.addEventListener("probo-ready", this.onReady, { once: true });
}
if (this.root.state === "banner") {
this.hidden = false;
}

View File

@@ -16,6 +16,7 @@ package coredata_test
import (
"context"
"net"
"net/url"
"os"
"testing"
@@ -52,7 +53,11 @@ func newTestPgClient(t *testing.T) *pg.Client {
// run in parallel.
opts := []pg.Option{pg.WithRegisterer(prometheus.NewRegistry())}
if u.Host != "" {
opts = append(opts, pg.WithAddr(u.Host))
host := u.Host
if u.Port() == "" {
host = net.JoinHostPort(u.Hostname(), "5432")
}
opts = append(opts, pg.WithAddr(host))
}
if u.User != nil {
opts = append(opts, pg.WithUser(u.User.Username()))