Enforce at least one owner

Signed-off-by: Bryan Frimin <bryan@getprobo.com>

pkg/coredata/membership_filter.go

@@ -21,6 +21,8 @@ import (
 
 type MembershipFilter struct {
 	email *mail.Addr
+	role  *MembershipRole
+	state *MembershipState
 }
 
 func NewMembershipFilter() *MembershipFilter {
@@ -36,9 +38,29 @@ func (f *MembershipFilter) Email() *mail.Addr {
 	return f.email
 }
 
+func (f *MembershipFilter) WithRole(role MembershipRole) *MembershipFilter {
+	f.role = &role
+	return f
+}
+
+func (f *MembershipFilter) Role() *MembershipRole {
+	return f.role
+}
+
+func (f *MembershipFilter) WithState(state MembershipState) *MembershipFilter {
+	f.state = &state
+	return f
+}
+
+func (f *MembershipFilter) State() *MembershipState {
+	return f.state
+}
+
 func (f *MembershipFilter) SQLArguments() pgx.StrictNamedArgs {
 	return pgx.StrictNamedArgs{
 		"filter_email": f.email,
+		"filter_role":  f.role,
+		"filter_state": f.state,
 	}
 }
 
@@ -50,5 +72,19 @@ func (f *MembershipFilter) SQLFragment() string {
 			i.email_address = @filter_email::text
 		ELSE TRUE
 	END
+)
+AND (
+	CASE
+		WHEN @filter_role::text IS NOT NULL THEN
+			m.role = @filter_role::authz_role
+		ELSE TRUE
+	END
+)
+AND (
+	CASE
+		WHEN @filter_state::text IS NOT NULL THEN
+			m.state = @filter_state::membership_state
+		ELSE TRUE
+	END
 )`
 }

pkg/iam/errors.go

@@ -147,6 +147,18 @@ func (e ErrMembershipManagedBySCIM) Error() string {
 	return fmt.Sprintf("membership %q is managed by SCIM and cannot be deleted manually", e.MembershipID)
 }
 
+type ErrLastActiveOwner struct {
+	MembershipID gid.GID
+}
+
+func NewLastActiveOwnerError(membershipID gid.GID) error {
+	return &ErrLastActiveOwner{MembershipID: membershipID}
+}
+
+func (e ErrLastActiveOwner) Error() string {
+	return fmt.Sprintf("cannot remove membership %q: last active owner of the organization", e.MembershipID)
+}
+
 type ErrOrganizationNotFound struct{ OrganizationID gid.GID }
 
 func NewOrganizationNotFoundError(organizationID gid.GID) error {

pkg/iam/organization_service.go

@@ -257,6 +257,21 @@ func (s *OrganizationService) RemoveMember(
 				return NewMembershipManagedBySCIMError(membershipID)
 			}
 
+			if membership.Role == coredata.MembershipRoleOwner && membership.State == coredata.MembershipStateActive {
+				memberships := coredata.Memberships{}
+				filter := coredata.NewMembershipFilter().
+					WithRole(coredata.MembershipRoleOwner).
+					WithState(coredata.MembershipStateActive)
+				count, err := memberships.CountByOrganizationID(ctx, tx, scope, organizationID, filter)
+				if err != nil {
+					return fmt.Errorf("cannot count active owners: %w", err)
+				}
+
+				if count <= 1 {
+					return NewLastActiveOwnerError(membershipID)
+				}
+			}
+
 			err := membership.Delete(ctx, tx, scope, membershipID)
 			if err != nil {
 				return fmt.Errorf("cannot delete membership: %w", err)

pkg/server/api/connect/v1/v1_resolver.go

@@ -968,10 +968,16 @@ func (r *mutationResolver) RemoveMember(ctx context.Context, input types.RemoveM
 	err := r.iam.OrganizationService.RemoveMember(ctx, input.OrganizationID, input.MembershipID)
 	if err != nil {
 		var errManagedBySCIM *iam.ErrMembershipManagedBySCIM
+		var errLastActiveOwner *iam.ErrLastActiveOwner
+
 		if errors.As(err, &errManagedBySCIM) {
 			return nil, gqlutils.Conflict(err)
 		}
 
+		if errors.As(err, &errLastActiveOwner) {
+			return nil, gqlutils.Conflict(err)
+		}
+
 		r.logger.ErrorCtx(ctx, "cannot remove member from organization", log.Error(err))
 		return nil, gqlutils.InternalServerError(ctx)
 	}