rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use one path for campaign source merge

Browse Source 
Remove early return on empty source IDs; count and MERGE always
run so clearing sources uses NOT MATCHED BY SOURCE delete.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-07-27 14:40:51 +00:00
parent 447bdb88e5
commit 4d154651a8
1 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
pkg/coredata/access_review_campaign_source.go
View File

@@ -161,25 +161,6 @@ func (sources *AccessReviewCampaignSources) MergeByCampaignID(
) error {
uniqueSourceIDs := uniqueGIDs(accessReviewSourceIDs)
if len(uniqueSourceIDs) == 0 {
q := `
DELETE FROM access_review_campaign_sources
WHERE
%s
AND access_review_campaign_id = @access_review_campaign_id
`
q = fmt.Sprintf(q, scope.SQLFragment())
args := pgx.StrictNamedArgs{"access_review_campaign_id": campaignID}
maps.Copy(args, scope.SQLArguments())
if _, err := conn.Exec(ctx, q, args); err != nil {
return fmt.Errorf("cannot delete campaign sources: %w", err)
}
return nil
}
sourceIDStrings := make([]string, len(uniqueSourceIDs))
for i, id := range uniqueSourceIDs {
sourceIDStrings[i] = id.String()