Fix approvers ui

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>

pkg/docgen/generator.go

@@ -204,7 +204,7 @@ type (
 		Content                     string
 		Version                     int
 		Classification              Classification
-		Approver                    string
+		Approvers                   []string
 		Description                 string
 		PublishedAt                 *time.Time
 		Signatures                  []SignatureData

pkg/docgen/generator_test.go

@@ -41,7 +41,7 @@ func TestRenderHTML(t *testing.T) {
 				Content:        "# Main Title\n\nThis is **bold** text with *italic* formatting.",
 				Version:        1,
 				Classification: ClassificationPublic,
-				Approver:       "John Doe",
+				Approvers:      []string{"John Doe"},
 				PublishedAt:    &now,
 				Signatures: []SignatureData{
 					{
@@ -66,9 +66,9 @@ func TestRenderHTML(t *testing.T) {
 		{
 			name: "document with HTML characters that need escaping",
 			data: DocumentData{
-				Title:    "Test & <Script> Title",
-				Content:  "Normal markdown content",
-				Approver: "John <script>alert('xss')</script> Doe",
+				Title:     "Test & <Script> Title",
+				Content:   "Normal markdown content",
+				Approvers: []string{"John <script>alert('xss')</script> Doe"},
 				Signatures: []SignatureData{
 					{
 						SignedBy: "Alice & <Bob>",
@@ -253,8 +253,8 @@ func TestClassificationConstants(t *testing.T) {
 
 func TestHTMLEscaping(t *testing.T) {
 	dangerousData := DocumentData{
-		Title:    "<script>alert('xss')</script>",
-		Approver: "User & <Company>",
+		Title:     "<script>alert('xss')</script>",
+		Approvers: []string{"User & <Company>"},
 		Signatures: []SignatureData{
 			{
 				SignedBy: "<malicious>tag",
@@ -385,7 +385,7 @@ func BenchmarkGenerateHTML(b *testing.B) {
 		Content:        "# Title\n\nThis is **bold** text with *italic* formatting.\n\n- Item 1\n- Item 2",
 		Version:        1,
 		Classification: ClassificationPublic,
-		Approver:       "John Doe",
+		Approvers:      []string{"John Doe"},
 		PublishedAt:    &now,
 		Signatures: []SignatureData{
 			{

pkg/docgen/template.html

@@ -363,8 +363,18 @@
                             </td>
                         </tr>
                         <tr>
-                            <td>Approver</td>
-                            <td>{{.Approver}}</td>
+                            <td>Approver{{- if gt (len .Approvers) 1}}s{{- end}}</td>
+                            <td>
+                                {{- if eq (len .Approvers) 1}}
+                                {{index .Approvers 0}}
+                                {{- else}}
+                                <ul style="margin: 0; padding-left: 18px;">
+                                {{- range .Approvers}}
+                                    <li>{{.}}</li>
+                                {{- end}}
+                                </ul>
+                                {{- end}}
+                            </td>
                         </tr>
                         <tr>
                             <td>Version:</td>

pkg/probo/document_service.go

@@ -1927,7 +1927,7 @@ func exportDocumentPDF(
 		Content:                     version.Content,
 		Version:                     version.VersionNumber,
 		Classification:              classification,
-		Approver:                    strings.Join(approverNames, ", "),
+		Approvers:                   approverNames,
 		PublishedAt:                 version.PublishedAt,
 		Signatures:                  signatureData,
 		CompanyHorizontalLogoBase64: horizontalLogoBase64,

pkg/trust/document_service.go

@@ -18,7 +18,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"strings"
 
 	"go.gearno.de/kit/pg"
 	"go.probo.inc/probo/pkg/coredata"
@@ -215,7 +214,7 @@ func (s *DocumentService) exportPDFData(
 		Content:                     version.Content,
 		Version:                     version.VersionNumber,
 		Classification:              classification,
-		Approver:                    strings.Join(approverNames, ", "),
+		Approvers:                   approverNames,
 		PublishedAt:                 version.PublishedAt,
 		CompanyHorizontalLogoBase64: horizontalLogoBase64,
 	}