rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Guard Crisp code copy against missing clipboard

Browse Source 
The verification-code copy handler called navigator.clipboard.writeText
directly and relied on the promise rejection for the failure toast. In
an insecure context or an unsupported embedded browser navigator.clipboard
is undefined, so the call throws synchronously before .then and neither
toast fires, leaving the user without the manual-copy guidance. Guard the
access and wrap the call in try/catch, mirroring ScopeDiagram, so the
failure toast is always shown.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-07-11 19:47:56 +02:00
parent d5102eac63
commit 2d124818d0
1 changed files with 29 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
apps/console/src/pages/organizations/access-reviews/dialogs/_components/APIKeyConnectorDialog.tsx
View File

@@ -349,22 +349,37 @@ export function APIKeyConnectorDialog({
type="button"
variant="secondary"
onClick={() => {
const onCopyFailure = () =>
toast({
title: __("Copy failed"),
description: __("Copy the verification code manually."),
variant: "error",
});
// navigator.clipboard is undefined in an insecure
// context or unsupported embedded browser, where
// writeText throws synchronously before .then; guard
// so the manual-copy toast still shows.
if (!navigator.clipboard?.writeText) {
onCopyFailure();
return;
}
// Copying feeds the Crisp connect flow, so only
// claim success once the write actually resolves.
navigator.clipboard.writeText(crispCodeState.code).then(
() =>
toast({
title: __("Copied to clipboard"),
description: __("Verification code"),
variant: "success",
}),
() =>
toast({
title: __("Copy failed"),
description: __("Copy the verification code manually."),
variant: "error",
}),
);
try {
navigator.clipboard.writeText(crispCodeState.code).then(
() =>
toast({
title: __("Copied to clipboard"),
description: __("Verification code"),
variant: "success",
}),
onCopyFailure,
);
} catch {
onCopyFailure();
}
}}
>
{__("Copy")}