Rename UpdateFrameworkPage -> EditFrameworkPage

Signed-off-by: Émile Ré <nemile.re@gmail.com>
This commit is contained in:
Émile Ré
2025-04-04 13:50:55 +04:00
parent 2141f14abf
commit 225bcf58d1
5 changed files with 46 additions and 49 deletions

View File

@@ -9,7 +9,7 @@ import { CreateFrameworkPage } from "./frameworks/CreateFrameworkPage";
import { FrameworkLayout } from "./frameworks/FrameworkLayout";
import { FrameworkListPage } from "./frameworks/FrameworkListPage";
import { FrameworkPage } from "./frameworks/FrameworkPage";
import { UpdateFrameworkPage } from "./frameworks/UpdateFrameworkPage";
import { EditFrameworkPage } from "./frameworks/EditFrameworkPage";
import { ControlPage } from "./frameworks/controls/ControlPage";
import { EditMitigationPage } from "./mitigations/EditMitigationPage";
import { MitigationListPage } from "./mitigations/MitigationListPage";
@@ -44,7 +44,7 @@ export function OrganizationsRoutes() {
<Route index element={<FrameworkPage />} />
<Route path="controls/:controlId" element={<ControlPage />} />
</Route>
<Route path="edit" element={<UpdateFrameworkPage />} />
<Route path="edit" element={<EditFrameworkPage />} />
<Route path="*" element={<NotFoundPage />} />
</Route>
<Route path="mitigations" element={<MitigationListPage />} />

View File

@@ -4,9 +4,9 @@ import { lazy } from "@probo/react-lazy";
import { useLocation } from "react-router";
import { ErrorBoundaryWithLocation } from "../ErrorBoundary";
const UpdateFrameworkView = lazy(() => import("./UpdateFrameworkView"));
const EditFrameworkView = lazy(() => import("./EditFrameworkView"));
export function UpdateFrameworkViewSkeleton() {
export function EditFrameworkViewSkeleton() {
return (
<PageTemplateSkeleton
title="Update Framework"
@@ -17,16 +17,13 @@ export function UpdateFrameworkViewSkeleton() {
);
}
export function UpdateFrameworkPage() {
export function EditFrameworkPage() {
const location = useLocation();
return (
<Suspense
key={location.pathname}
fallback={<UpdateFrameworkViewSkeleton />}
>
<Suspense key={location.pathname} fallback={<EditFrameworkViewSkeleton />}>
<ErrorBoundaryWithLocation>
<UpdateFrameworkView />
<EditFrameworkView />
</ErrorBoundaryWithLocation>
</Suspense>
);

View File

@@ -15,13 +15,13 @@ import { Textarea } from "@/components/ui/textarea";
import { useToast } from "@/hooks/use-toast";
import { HelpCircle } from "lucide-react";
import { cn } from "@/lib/utils";
import { UpdateFrameworkViewUpdateFrameworkMutation } from "./__generated__/UpdateFrameworkViewUpdateFrameworkMutation.graphql";
import { UpdateFrameworkViewQuery as UpdateFrameworkViewQueryType } from "./__generated__/UpdateFrameworkViewQuery.graphql";
import { EditFrameworkViewUpdateFrameworkMutation } from "./__generated__/EditFrameworkViewUpdateFrameworkMutation.graphql";
import { EditFrameworkViewQuery } from "./__generated__/EditFrameworkViewQuery.graphql";
import { PageTemplate } from "@/components/PageTemplate";
import { UpdateFrameworkViewSkeleton } from "./UpdateFrameworkPage";
import { EditFrameworkViewSkeleton } from "./EditFrameworkPage";
const updateFrameworkMutation = graphql`
mutation UpdateFrameworkViewUpdateFrameworkMutation(
mutation EditFrameworkViewUpdateFrameworkMutation(
$input: UpdateFrameworkInput!
) {
updateFramework(input: $input) {
@@ -34,8 +34,8 @@ const updateFrameworkMutation = graphql`
}
`;
const updateFrameworkQuery = graphql`
query UpdateFrameworkViewQuery($frameworkId: ID!) {
const editFrameworkQuery = graphql`
query EditFrameworkViewQuery($frameworkId: ID!) {
node(id: $frameworkId) {
... on Framework {
id
@@ -107,15 +107,15 @@ function EditableField({
);
}
function UpdateFrameworkViewContent({
function EditFrameworkViewContent({
queryRef,
}: {
queryRef: PreloadedQuery<UpdateFrameworkViewQueryType>;
queryRef: PreloadedQuery<EditFrameworkViewQuery>;
}) {
const { organizationId, frameworkId } = useParams();
const navigate = useNavigate();
const { toast } = useToast();
const data = usePreloadedQuery(updateFrameworkQuery, queryRef);
const data = usePreloadedQuery(editFrameworkQuery, queryRef);
const [, setEditedFields] = useState<Set<string>>(new Set());
const [formData, setFormData] = useState({
name: "",
@@ -132,7 +132,7 @@ function UpdateFrameworkViewContent({
}, [data.node]);
const [commit, isInFlight] =
useMutation<UpdateFrameworkViewUpdateFrameworkMutation>(
useMutation<EditFrameworkViewUpdateFrameworkMutation>(
updateFrameworkMutation
);
@@ -232,10 +232,10 @@ function UpdateFrameworkViewContent({
);
}
export default function UpdateFrameworkView() {
export default function EditFrameworkView() {
const { frameworkId } = useParams();
const [queryRef, loadQuery] =
useQueryLoader<UpdateFrameworkViewQueryType>(updateFrameworkQuery);
useQueryLoader<EditFrameworkViewQuery>(editFrameworkQuery);
useEffect(() => {
if (frameworkId) {
@@ -244,12 +244,12 @@ export default function UpdateFrameworkView() {
}, [frameworkId, loadQuery]);
if (!queryRef) {
return <UpdateFrameworkViewSkeleton />;
return <EditFrameworkViewSkeleton />;
}
return (
<Suspense fallback={<UpdateFrameworkViewSkeleton />}>
<UpdateFrameworkViewContent queryRef={queryRef} />
<Suspense fallback={<EditFrameworkViewSkeleton />}>
<EditFrameworkViewContent queryRef={queryRef} />
</Suspense>
);
}

View File

@@ -1,5 +1,5 @@
/**
* @generated SignedSource<<f6c5cb8b7001a4cee689302191d06ad9>>
* @generated SignedSource<<893e92f87ebfab909780d937879680d9>>
* @lightSyntaxTransform
* @nogrep
*/
@@ -9,19 +9,19 @@
// @ts-nocheck
import { ConcreteRequest } from 'relay-runtime';
export type UpdateFrameworkViewQuery$variables = {
export type EditFrameworkViewQuery$variables = {
frameworkId: string;
};
export type UpdateFrameworkViewQuery$data = {
export type EditFrameworkViewQuery$data = {
readonly node: {
readonly description?: string;
readonly id?: string;
readonly name?: string;
};
};
export type UpdateFrameworkViewQuery = {
response: UpdateFrameworkViewQuery$data;
variables: UpdateFrameworkViewQuery$variables;
export type EditFrameworkViewQuery = {
response: EditFrameworkViewQuery$data;
variables: EditFrameworkViewQuery$variables;
};
const node: ConcreteRequest = (function(){
@@ -65,7 +65,7 @@ return {
"argumentDefinitions": (v0/*: any*/),
"kind": "Fragment",
"metadata": null,
"name": "UpdateFrameworkViewQuery",
"name": "EditFrameworkViewQuery",
"selections": [
{
"alias": null,
@@ -96,7 +96,7 @@ return {
"operation": {
"argumentDefinitions": (v0/*: any*/),
"kind": "Operation",
"name": "UpdateFrameworkViewQuery",
"name": "EditFrameworkViewQuery",
"selections": [
{
"alias": null,
@@ -129,16 +129,16 @@ return {
]
},
"params": {
"cacheID": "5c423e61373989c4576989cb6c732547",
"cacheID": "2a55a5cc00d16dcb7d978dfcfbfcf8e6",
"id": null,
"metadata": {},
"name": "UpdateFrameworkViewQuery",
"name": "EditFrameworkViewQuery",
"operationKind": "query",
"text": "query UpdateFrameworkViewQuery(\n $frameworkId: ID!\n) {\n node(id: $frameworkId) {\n __typename\n ... on Framework {\n id\n name\n description\n }\n id\n }\n}\n"
"text": "query EditFrameworkViewQuery(\n $frameworkId: ID!\n) {\n node(id: $frameworkId) {\n __typename\n ... on Framework {\n id\n name\n description\n }\n id\n }\n}\n"
}
};
})();
(node as any).hash = "416b7f0dbf33cbfe39578fc3243bf423";
(node as any).hash = "b5a785e12393d6b16ddcc1750a6aa381";
export default node;

View File

@@ -1,5 +1,5 @@
/**
* @generated SignedSource<<9c98acb5c320005e303cd815550c0d74>>
* @generated SignedSource<<eccd1c8953dd5a4b93817a53ed43e3c4>>
* @lightSyntaxTransform
* @nogrep
*/
@@ -14,10 +14,10 @@ export type UpdateFrameworkInput = {
id: string;
name?: string | null | undefined;
};
export type UpdateFrameworkViewUpdateFrameworkMutation$variables = {
export type EditFrameworkViewUpdateFrameworkMutation$variables = {
input: UpdateFrameworkInput;
};
export type UpdateFrameworkViewUpdateFrameworkMutation$data = {
export type EditFrameworkViewUpdateFrameworkMutation$data = {
readonly updateFramework: {
readonly framework: {
readonly description: string;
@@ -26,9 +26,9 @@ export type UpdateFrameworkViewUpdateFrameworkMutation$data = {
};
};
};
export type UpdateFrameworkViewUpdateFrameworkMutation = {
response: UpdateFrameworkViewUpdateFrameworkMutation$data;
variables: UpdateFrameworkViewUpdateFrameworkMutation$variables;
export type EditFrameworkViewUpdateFrameworkMutation = {
response: EditFrameworkViewUpdateFrameworkMutation$data;
variables: EditFrameworkViewUpdateFrameworkMutation$variables;
};
const node: ConcreteRequest = (function(){
@@ -95,7 +95,7 @@ return {
"argumentDefinitions": (v0/*: any*/),
"kind": "Fragment",
"metadata": null,
"name": "UpdateFrameworkViewUpdateFrameworkMutation",
"name": "EditFrameworkViewUpdateFrameworkMutation",
"selections": (v1/*: any*/),
"type": "Mutation",
"abstractKey": null
@@ -104,20 +104,20 @@ return {
"operation": {
"argumentDefinitions": (v0/*: any*/),
"kind": "Operation",
"name": "UpdateFrameworkViewUpdateFrameworkMutation",
"name": "EditFrameworkViewUpdateFrameworkMutation",
"selections": (v1/*: any*/)
},
"params": {
"cacheID": "8a41e224572c2419fc49c7fef6908d63",
"cacheID": "672c40ecde91237ef059320284b9d1c6",
"id": null,
"metadata": {},
"name": "UpdateFrameworkViewUpdateFrameworkMutation",
"name": "EditFrameworkViewUpdateFrameworkMutation",
"operationKind": "mutation",
"text": "mutation UpdateFrameworkViewUpdateFrameworkMutation(\n $input: UpdateFrameworkInput!\n) {\n updateFramework(input: $input) {\n framework {\n id\n name\n description\n }\n }\n}\n"
"text": "mutation EditFrameworkViewUpdateFrameworkMutation(\n $input: UpdateFrameworkInput!\n) {\n updateFramework(input: $input) {\n framework {\n id\n name\n description\n }\n }\n}\n"
}
};
})();
(node as any).hash = "9b201a966e844a77d3d920a7e0165d15";
(node as any).hash = "8fe1fd5bf26bce25a31cb724bcedec9f";
export default node;