rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename ErrCampaignNoScopeSources to ErrCampaignNoSourcesSelected

Browse Source 
Align the sentinel name with the validation it represents.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This commit is contained in:
Cursor Agent
2026-07-20 15:46:05 +00:00
parent 0870e1dd15
commit 1dcfa31dab
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/accessreview/campaign_service.go
View File

@@ -428,7 +428,7 @@ func (s *Service) StartCampaign(
} }
if len(campaignSources) == 0 { if len(campaignSources) == 0 {
return ErrCampaignNoScopeSources return ErrCampaignNoSourcesSelected
} }
now := time.Now() now := time.Now()

2
pkg/accessreview/errors.go
View File

@@ -23,7 +23,7 @@ package accessreview
import "errors" import "errors"
var ( var (
ErrCampaignNoScopeSources = errors.New("cannot start campaign: no scope sources configured") ErrCampaignNoSourcesSelected = errors.New("cannot start campaign: no scope sources configured")
ErrCampaignNotDraft = errors.New("campaign must be in draft status") ErrCampaignNotDraft = errors.New("campaign must be in draft status")
ErrCampaignSourceOrganizationMismatch = errors.New("access source does not belong to the same organization") ErrCampaignSourceOrganizationMismatch = errors.New("access source does not belong to the same organization")
) )

2
pkg/server/api/console/v1/access_review_campaign_resolvers.go
View File

@@ -806,7 +806,7 @@ func (r *mutationResolver) StartAccessReviewCampaign(ctx context.Context, input
campaign, err := r.accessReview.StartCampaign(ctx, scope, input.AccessReviewCampaignID) campaign, err := r.accessReview.StartCampaign(ctx, scope, input.AccessReviewCampaignID)
if err != nil { if err != nil {
if errors.Is(err, accessreview.ErrCampaignNoScopeSources) || if errors.Is(err, accessreview.ErrCampaignNoSourcesSelected) ||
errors.Is(err, accessreview.ErrCampaignNotDraft) { errors.Is(err, accessreview.ErrCampaignNotDraft) {
return nil, gqlutils.Invalid(ctx, err) return nil, gqlutils.Invalid(ctx, err)
} }