From 1dcfa31daba817e7473deb1b78c9f50618748e45 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Mon, 20 Jul 2026 15:46:05 +0000 Subject: [PATCH] Rename ErrCampaignNoScopeSources to ErrCampaignNoSourcesSelected Align the sentinel name with the validation it represents. Signed-off-by: Cursor Agent Co-authored-by: Bryan FRIMIN --- pkg/accessreview/campaign_service.go | 2 +- pkg/accessreview/errors.go | 2 +- pkg/server/api/console/v1/access_review_campaign_resolvers.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/accessreview/campaign_service.go b/pkg/accessreview/campaign_service.go index 3360150e1..e4a36748a 100644 --- a/pkg/accessreview/campaign_service.go +++ b/pkg/accessreview/campaign_service.go @@ -428,7 +428,7 @@ func (s *Service) StartCampaign( } if len(campaignSources) == 0 { - return ErrCampaignNoScopeSources + return ErrCampaignNoSourcesSelected } now := time.Now() diff --git a/pkg/accessreview/errors.go b/pkg/accessreview/errors.go index 62db3b9a3..f5eb3d911 100644 --- a/pkg/accessreview/errors.go +++ b/pkg/accessreview/errors.go @@ -23,7 +23,7 @@ package accessreview import "errors" var ( - ErrCampaignNoScopeSources = errors.New("cannot start campaign: no scope sources configured") + ErrCampaignNoSourcesSelected = errors.New("cannot start campaign: no scope sources configured") ErrCampaignNotDraft = errors.New("campaign must be in draft status") ErrCampaignSourceOrganizationMismatch = errors.New("access source does not belong to the same organization") ) diff --git a/pkg/server/api/console/v1/access_review_campaign_resolvers.go b/pkg/server/api/console/v1/access_review_campaign_resolvers.go index e507e7e17..e451cafc8 100644 --- a/pkg/server/api/console/v1/access_review_campaign_resolvers.go +++ b/pkg/server/api/console/v1/access_review_campaign_resolvers.go @@ -806,7 +806,7 @@ func (r *mutationResolver) StartAccessReviewCampaign(ctx context.Context, input campaign, err := r.accessReview.StartCampaign(ctx, scope, input.AccessReviewCampaignID) if err != nil { - if errors.Is(err, accessreview.ErrCampaignNoScopeSources) || + if errors.Is(err, accessreview.ErrCampaignNoSourcesSelected) || errors.Is(err, accessreview.ErrCampaignNotDraft) { return nil, gqlutils.Invalid(ctx, err) }