Drop Helm wiring for the 9 new access-review connectors → Drop e2e TODO about access-review connector coverage gap

- Drop Helm wiring for the 9 new access-review connectors
- Drop e2e TODO about access-review connector coverage gap

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-05-17 17:22:51 +02:00
parent 7d0dec82f6
commit 0d6484a0ef
4 changed files with 0 additions and 61 deletions

View File

@@ -281,36 +281,6 @@ spec:
{{- end }}
{{- end }}
{{- end }}
# Connectors (access-review OAuth2 providers added 2026)
{{- range .Values.probo.connectors }}
{{- $accessReviewProviders := list "gitlab" "bitbucket" "heroku" "pagerduty" "asana" "netlify" "clickup" "vercel" "monday" }}
{{- if has .name $accessReviewProviders }}
{{- $envPrefix := printf "CONNECTOR_%s" (.name | upper) }}
{{- $secretPrefix := printf "connector-%s" .name }}
{{- if .config.clientId }}
- name: {{ $envPrefix }}_CLIENT_ID
valueFrom:
secretKeyRef:
name: {{ include "probo.fullname" $ }}
key: {{ $secretPrefix }}-client-id
{{- end }}
{{- if .config.clientSecret }}
- name: {{ $envPrefix }}_CLIENT_SECRET
valueFrom:
secretKeyRef:
name: {{ include "probo.fullname" $ }}
key: {{ $secretPrefix }}-client-secret
{{- end }}
{{- if .config.redirectUri }}
- name: {{ $envPrefix }}_REDIRECT_URI
value: {{ .config.redirectUri | quote }}
{{- end }}
{{- if and (eq .name "vercel") .config.integrationSlug }}
- name: CONNECTOR_VERCEL_INTEGRATION_SLUG
value: {{ .config.integrationSlug | quote }}
{{- end }}
{{- end }}
{{- end }}
ports:
- name: http
containerPort: {{ .Values.service.httpPort }}

View File

@@ -56,13 +56,4 @@ stringData:
connector-slack-signing-secret: {{ .config.signingSecret | quote }}
{{- end }}
{{- end }}
{{- $accessReviewProviders := list "gitlab" "bitbucket" "heroku" "pagerduty" "asana" "netlify" "clickup" "vercel" "monday" }}
{{- if has .name $accessReviewProviders }}
{{- if .config.clientId }}
connector-{{ .name }}-client-id: {{ .config.clientId | quote }}
{{- end }}
{{- if .config.clientSecret }}
connector-{{ .name }}-client-secret: {{ .config.clientSecret | quote }}
{{- end }}
{{- end }}
{{- end }}

View File

@@ -181,15 +181,6 @@ probo:
insecureTls: false
# External OAuth2 connectors (optional)
#
# Supported providers (set name to one of):
# slack, hubspot, docusign, notion, github, sentry, intercom, brex,
# google_workspace, gitlab, bitbucket, heroku, pagerduty, asana,
# netlify, clickup, vercel, monday
#
# Vercel additionally requires "integration-slug" so the templated
# AuthURL ("https://vercel.com/integrations/{integration_slug}/new")
# resolves to the operator's registered integration.
connectors:
- name: "github"
type: "oauth2"
@@ -199,12 +190,6 @@ probo:
redirect-uri: "https://probo.example.com/api/console/v1/connectors/complete"
auth-url: "https://github.com/login/oauth/authorize"
token-url: "https://github.com/login/oauth/access_token"
# - name: "vercel"
# type: "oauth2"
# config:
# client-id: "CHANGE_ME_VERCEL_CLIENT_ID"
# client-secret: "CHANGE_ME_VERCEL_CLIENT_SECRET"
# integration-slug: "CHANGE_ME_VERCEL_INTEGRATION_SLUG"
# PostgreSQL configuration (REQUIRED)
# For production: Use external managed PostgreSQL (AWS RDS, GCP Cloud SQL, etc.)