Drop Helm wiring for the 9 new access-review connectors → Drop e2e TODO about access-review connector coverage gap

- Drop Helm wiring for the 9 new access-review connectors
- Drop e2e TODO about access-review connector coverage gap

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>

contrib/helm/charts/probo/templates/deployment.yaml

@@ -281,36 +281,6 @@ spec:
             {{- end }}
             {{- end }}
             {{- end }}
-            # Connectors (access-review OAuth2 providers added 2026)
-            {{- range .Values.probo.connectors }}
-            {{- $accessReviewProviders := list "gitlab" "bitbucket" "heroku" "pagerduty" "asana" "netlify" "clickup" "vercel" "monday" }}
-            {{- if has .name $accessReviewProviders }}
-            {{- $envPrefix := printf "CONNECTOR_%s" (.name | upper) }}
-            {{- $secretPrefix := printf "connector-%s" .name }}
-            {{- if .config.clientId }}
-            - name: {{ $envPrefix }}_CLIENT_ID
-              valueFrom:
-                secretKeyRef:
-                  name: {{ include "probo.fullname" $ }}
-                  key: {{ $secretPrefix }}-client-id
-            {{- end }}
-            {{- if .config.clientSecret }}
-            - name: {{ $envPrefix }}_CLIENT_SECRET
-              valueFrom:
-                secretKeyRef:
-                  name: {{ include "probo.fullname" $ }}
-                  key: {{ $secretPrefix }}-client-secret
-            {{- end }}
-            {{- if .config.redirectUri }}
-            - name: {{ $envPrefix }}_REDIRECT_URI
-              value: {{ .config.redirectUri | quote }}
-            {{- end }}
-            {{- if and (eq .name "vercel") .config.integrationSlug }}
-            - name: CONNECTOR_VERCEL_INTEGRATION_SLUG
-              value: {{ .config.integrationSlug | quote }}
-            {{- end }}
-            {{- end }}
-            {{- end }}
           ports:
             - name: http
               containerPort: {{ .Values.service.httpPort }}

contrib/helm/charts/probo/templates/secret.yaml

@@ -56,13 +56,4 @@ stringData:
   connector-slack-signing-secret: {{ .config.signingSecret | quote }}
   {{- end }}
   {{- end }}
-  {{- $accessReviewProviders := list "gitlab" "bitbucket" "heroku" "pagerduty" "asana" "netlify" "clickup" "vercel" "monday" }}
-  {{- if has .name $accessReviewProviders }}
-  {{- if .config.clientId }}
-  connector-{{ .name }}-client-id: {{ .config.clientId | quote }}
-  {{- end }}
-  {{- if .config.clientSecret }}
-  connector-{{ .name }}-client-secret: {{ .config.clientSecret | quote }}
-  {{- end }}
-  {{- end }}
   {{- end }}

contrib/helm/charts/probo/values-production.yaml.example

@@ -181,15 +181,6 @@ probo:
       insecureTls: false
 
   # External OAuth2 connectors (optional)
-  #
-  # Supported providers (set name to one of):
-  #   slack, hubspot, docusign, notion, github, sentry, intercom, brex,
-  #   google_workspace, gitlab, bitbucket, heroku, pagerduty, asana,
-  #   netlify, clickup, vercel, monday
-  #
-  # Vercel additionally requires "integration-slug" so the templated
-  # AuthURL ("https://vercel.com/integrations/{integration_slug}/new")
-  # resolves to the operator's registered integration.
   connectors:
     - name: "github"
       type: "oauth2"
@@ -199,12 +190,6 @@ probo:
         redirect-uri: "https://probo.example.com/api/console/v1/connectors/complete"
         auth-url: "https://github.com/login/oauth/authorize"
         token-url: "https://github.com/login/oauth/access_token"
-    # - name: "vercel"
-    #   type: "oauth2"
-    #   config:
-    #     client-id: "CHANGE_ME_VERCEL_CLIENT_ID"
-    #     client-secret: "CHANGE_ME_VERCEL_CLIENT_SECRET"
-    #     integration-slug: "CHANGE_ME_VERCEL_INTEGRATION_SLUG"
 
 # PostgreSQL configuration (REQUIRED)
 # For production: Use external managed PostgreSQL (AWS RDS, GCP Cloud SQL, etc.)

e2e/console/access_review_test.go

@@ -26,13 +26,6 @@ import (
 
 const testCsvData = "email,full_name,role,job_title,is_admin,mfa_status,auth_method,last_login,account_created_at,external_id\njane@example.com,Jane Smith,admin,CTO,true,ENABLED,SSO,2026-01-15T00:00:00Z,2024-06-01T00:00:00Z,ext-jane"
 
-// TODO(access-review-connectors): add e2e tests for the new GitLab,
-// Bitbucket, Heroku, PagerDuty, Asana, Netlify, ClickUp, Vercel, and
-// Monday.com access-source connectors once the e2e factory grows
-// OAuth2-connector seed support for arbitrary providers. For now the
-// per-driver VCR tests under pkg/accessreview/drivers cover the fetch
-// path; this e2e suite still exercises CSV + Slack which were the
-// providers wired before these sprints.
 func TestAccessSource_Create(t *testing.T) {
 	t.Parallel()
 	owner := testutil.NewClient(t, testutil.RoleOwner)