c50d2657f4
The Brex name resolver calls GET /v2/company to build the source display name, but the connector only requested openid, offline_access, and users.readonly -- and users.readonly covers /v2/users (the account fetch), not /v2/company. So the company endpoint 403'd for every Brex source, which the source-name worker retried forever (2.9M errors in 7 days) until the terminal-error handling stopped the loop. Add companies.readonly so the endpoint resolves. Verified as the exact scope string against Brex's OAuth authorize flow (the "Companies: Read only" developer scope maps to companies.readonly). Existing Brex connectors must reconnect to re-consent to the added scope; until they do, /v2/company still 403s but is now handled cleanly (terminal -> generic name, no loop) rather than silently retried. Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
53 lines
2.3 KiB
Go
53 lines
2.3 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
package provider
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
|
|
"go.gearno.de/kit/log"
|
|
"go.probo.inc/probo/pkg/accessreview/drivers"
|
|
"go.probo.inc/probo/pkg/coredata"
|
|
)
|
|
|
|
func brexRegistration() *Registration {
|
|
return &Registration{
|
|
Provider: coredata.ConnectorProviderBrex,
|
|
DisplayName: "Brex",
|
|
AuthURL: "https://accounts-api.brex.com/oauth2/default/v1/authorize",
|
|
TokenURL: "https://accounts-api.brex.com/oauth2/default/v1/token",
|
|
ProbeURL: "https://platform.brexapis.com/v2/users/me",
|
|
// companies.readonly is required by the name resolver's GET /v2/company
|
|
// call; without it Brex 403s that endpoint (users.readonly covers only
|
|
// /v2/users, which the driver uses). Existing Brex connectors must
|
|
// reconnect to re-consent to the added scope.
|
|
OAuth2Scopes: []string{"openid", "offline_access", "users.readonly", "companies.readonly"},
|
|
SupportsAPIKey: true,
|
|
NewDriver: func(_ context.Context, c *http.Client, _ *coredata.Connector, _ *log.Logger) (drivers.Driver, error) {
|
|
return drivers.NewBrexDriver(c), nil
|
|
},
|
|
NewNameResolver: func(_ context.Context, c *http.Client, _ *coredata.Connector, _ *log.Logger) drivers.NameResolver {
|
|
return drivers.NewBrexNameResolver(c)
|
|
},
|
|
}
|
|
}
|