A fetch runs under a 30-second per-source budget, but the retry transport slept without reference to it, so backoff could convert a reportable provider status into an opaque "context deadline exceeded". Three changes. The final attempt no longer sleeps: nothing follows it, so the wait only spent the caller's deadline to return a response already in hand — up to a second per failed request, across sixteen drivers. Retry-After is now honoured, in both the delta-seconds and HTTP-date forms; ignoring it meant retrying a 429 after 250ms and earning another 429, spending the whole retry budget in under a second. And a wait is skipped entirely when it exceeds the remaining deadline or a 5s cap, because a retry that lands after the deadline cannot succeed — the throttled response is surfaced instead so the caller reports what the provider actually said. The type moves from google_workspace.go to driver.go, which is where the other shared driver machinery lives; sixteen drivers construct it and none of them are Google Workspace. It had no tests, so it has them now. Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
251 lines
8.2 KiB
Go
251 lines
8.2 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in
|
|
// all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
package drivers
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"go.probo.inc/probo/pkg/coredata"
|
|
)
|
|
|
|
// AccountRecord represents a single account from an access source or identity
|
|
// source. All fields are best-effort; sources populate what they can. Drivers
|
|
// must return ALL accounts the source exposes (including inactive / suspended
|
|
// / deleted); classification is the job of the reviewer or of an agent run
|
|
// against the campaign, not of the fetch pipeline.
|
|
//
|
|
// Active is three-valued: nil means the source API has no explicit
|
|
// account-status signal for this account (the driver cannot tell), a non-nil
|
|
// pointer means the driver observed an explicit signal (true = active at
|
|
// source, false = deactivated / suspended / deleted). Drivers whose API does
|
|
// not distinguish active from deactivated accounts must leave Active nil
|
|
// rather than fabricate a value.
|
|
type AccountRecord struct {
|
|
Email string
|
|
FullName string
|
|
Roles []string // system roles/permissions (e.g. "Admin", "Viewer")
|
|
JobTitle string // HR job title / department (e.g. "Software Engineer")
|
|
Active *bool
|
|
IsAdmin bool
|
|
MFAStatus coredata.MFAStatus
|
|
AuthMethod coredata.AccessReviewEntryAuthMethod
|
|
AccountType coredata.AccessReviewEntryAccountType
|
|
LastLogin *time.Time
|
|
CreatedAt *time.Time
|
|
ExternalID string // system-specific user ID
|
|
}
|
|
|
|
// maxPaginationPages is the upper bound on the number of pages a driver will
|
|
// fetch from an external API. This prevents infinite loops if an API returns
|
|
// a non-empty cursor on every response.
|
|
const maxPaginationPages = 500
|
|
|
|
// ErrPaginationLimitReached is returned when a driver exhausts the maximum
|
|
// number of pagination pages without reaching the end of the result set.
|
|
var ErrPaginationLimitReached = fmt.Errorf("pagination limit of %d pages reached", maxPaginationPages)
|
|
|
|
// Driver defines the interface for fetching accounts from an access or
|
|
// identity source. Each driver implementation corresponds to a specific
|
|
// system (e.g. Google Workspace, AWS IAM, Probo memberships, CSV).
|
|
//
|
|
// All sources in a campaign's scope return "who actually has access" data.
|
|
type Driver interface {
|
|
// ListAccounts returns all accounts from the source system.
|
|
ListAccounts(ctx context.Context) ([]AccountRecord, error)
|
|
}
|
|
|
|
// parseRFC3339Ptr parses an RFC 3339 timestamp into a *time.Time, returning
|
|
// nil for an empty or unparseable value. Drivers use it for best-effort
|
|
// timestamp fields (created_at, last_login_at) that an API may omit.
|
|
func parseRFC3339Ptr(s string) *time.Time {
|
|
if s == "" {
|
|
return nil
|
|
}
|
|
|
|
t, err := time.Parse(time.RFC3339, s)
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
|
|
return &t
|
|
}
|
|
|
|
// activeFromStatus maps a provider status string to the three-valued Active
|
|
// signal for providers whose only "live" state is the literal "active" and
|
|
// whose remaining status enum is not otherwise enumerated: "active" → active,
|
|
// an empty status → nil (no signal), and any other non-empty status →
|
|
// inactive. Used by drivers like Pylon and Brevo; a provider with a fully
|
|
// known status enum (e.g. Render's active/inactive) maps its own values
|
|
// explicitly instead, so an unrecognised value stays nil rather than false.
|
|
func activeFromStatus(status string) *bool {
|
|
switch strings.ToLower(strings.TrimSpace(status)) {
|
|
case "active":
|
|
active := true
|
|
|
|
return &active
|
|
case "":
|
|
return nil
|
|
default:
|
|
inactive := false
|
|
|
|
return &inactive
|
|
}
|
|
}
|
|
|
|
// ownerMemberRoles maps a provider role to a display label for providers whose
|
|
// role model is exactly owner/member (e.g. Crisp operators, Scaleway org user
|
|
// types): "owner" → Owner, "member" → Member. An unknown future value is passed
|
|
// through verbatim and no role yields an empty slice.
|
|
func ownerMemberRoles(role string) []string {
|
|
switch strings.ToLower(strings.TrimSpace(role)) {
|
|
case "owner":
|
|
return []string{"Owner"}
|
|
case "member":
|
|
return []string{"Member"}
|
|
default:
|
|
if r := strings.TrimSpace(role); r != "" {
|
|
return []string{r}
|
|
}
|
|
|
|
return []string{}
|
|
}
|
|
}
|
|
|
|
// isOwnerRole reports whether a provider role is the owner, the only role in the
|
|
// owner/member model that grants administrative access.
|
|
func isOwnerRole(role string) bool {
|
|
return strings.EqualFold(strings.TrimSpace(role), "owner")
|
|
}
|
|
|
|
// retryRoundTripper retries 429 and 5xx responses with exponential backoff.
|
|
//
|
|
// The retry budget is bounded by what can still produce a useful answer: a
|
|
// fetch runs under a per-source deadline, so a sleep that outlives the
|
|
// deadline, or that follows the final attempt, only converts a reportable
|
|
// provider status into an opaque timeout. Every wait below is therefore
|
|
// guarded.
|
|
type retryRoundTripper struct {
|
|
next http.RoundTripper
|
|
maxRetries int
|
|
}
|
|
|
|
const (
|
|
// retryBaseBackoff is the first backoff step; it doubles per attempt.
|
|
retryBaseBackoff = 250 * time.Millisecond
|
|
// maxRetryWait caps a single wait. A provider asking for longer (via
|
|
// Retry-After) cannot be accommodated inside a per-source budget, so the
|
|
// throttled response is returned instead and the caller reports it.
|
|
maxRetryWait = 5 * time.Second
|
|
)
|
|
|
|
func (rt *retryRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
|
|
transport := rt.next
|
|
if transport == nil {
|
|
transport = http.DefaultTransport
|
|
}
|
|
|
|
var lastResp *http.Response
|
|
|
|
for attempt := range rt.maxRetries {
|
|
resp, err := transport.RoundTrip(req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if resp.StatusCode != http.StatusTooManyRequests && resp.StatusCode < 500 {
|
|
return resp, nil
|
|
}
|
|
|
|
// Buffer and re-attach the body so the caller can still read it
|
|
// if this turns out to be the final (retry-exhausted) response.
|
|
body, _ := io.ReadAll(resp.Body)
|
|
_ = resp.Body.Close()
|
|
resp.Body = io.NopCloser(bytes.NewReader(body))
|
|
lastResp = resp
|
|
|
|
// Nothing follows the last attempt, so waiting here would burn the
|
|
// caller's deadline to return the response it already has.
|
|
if attempt == rt.maxRetries-1 {
|
|
break
|
|
}
|
|
|
|
wait := retryBaseBackoff << attempt
|
|
// Retry-After is authoritative on 429: retrying sooner just earns
|
|
// another 429 and spends an attempt doing it.
|
|
if after, ok := retryAfter(resp); ok {
|
|
wait = after
|
|
}
|
|
|
|
if wait > maxRetryWait {
|
|
break
|
|
}
|
|
|
|
// Sleeping past the deadline guarantees a context error that hides
|
|
// the provider's actual status from the caller.
|
|
if deadline, ok := req.Context().Deadline(); ok && time.Until(deadline) <= wait {
|
|
break
|
|
}
|
|
|
|
timer := time.NewTimer(wait)
|
|
|
|
select {
|
|
case <-req.Context().Done():
|
|
timer.Stop()
|
|
|
|
return nil, req.Context().Err()
|
|
case <-timer.C:
|
|
}
|
|
}
|
|
|
|
return lastResp, nil
|
|
}
|
|
|
|
// retryAfter reads a Retry-After header in either documented form —
|
|
// delta-seconds or an HTTP-date. The bool reports whether the header was
|
|
// present and parseable; a date already in the past yields a zero wait.
|
|
func retryAfter(resp *http.Response) (time.Duration, bool) {
|
|
value := strings.TrimSpace(resp.Header.Get("Retry-After"))
|
|
if value == "" {
|
|
return 0, false
|
|
}
|
|
|
|
if seconds, err := strconv.Atoi(value); err == nil {
|
|
if seconds < 0 {
|
|
return 0, false
|
|
}
|
|
|
|
return time.Duration(seconds) * time.Second, true
|
|
}
|
|
|
|
if at, err := http.ParseTime(value); err == nil {
|
|
return max(time.Until(at), 0), true
|
|
}
|
|
|
|
return 0, false
|
|
}
|