An organization ADMIN could hard-remove members, including OWNERs, because removeUser (connect and MCP) only checked the weaker iam:membership-profile:delete gate. Authorize the owner-only iam:membership:delete instead, and expose the source attribute on MembershipProfile so the owner grant's non-SCIM condition can match. Consolidate ownership-grant authorization into policy for both createUser and updateMembership: each resolver passes the requested role as a target_role attribute and ADMIN is denied granting ownership via deny-create-owner / deny-promote-owner. target_role is distinct from resource.role, which is the target's current role and guards editing existing owners. With no callers left, the iam:membership-role:set-owner action (grant and OAuth2 scope) is removed. Also pass the authorized scope through to the RemoveUser/CreateUser services, gate the console Remove action on iam:membership:delete, and add regression tests plus a changelog entry. Signed-off-by: Sacha Al Himdani <sacha@probo.com>
156 lines
4.6 KiB
Go
156 lines
4.6 KiB
Go
// Copyright (c) 2025-2026 Probo Inc <hello@probo.com>.
|
|
//
|
|
// Permission to use, copy, modify, and/or distribute this software for any
|
|
// purpose with or without fee is hereby granted, provided that the above
|
|
// copyright notice and this permission notice appear in all copies.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
|
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
|
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
|
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
|
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
|
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
|
// PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
//go:generate go run go.probo.inc/mcpgen generate
|
|
|
|
package mcp_v1
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"go.gearno.de/kit/log"
|
|
"go.probo.inc/probo/pkg/accessreview"
|
|
"go.probo.inc/probo/pkg/baseurl"
|
|
"go.probo.inc/probo/pkg/cookiebanner"
|
|
"go.probo.inc/probo/pkg/coredata"
|
|
"go.probo.inc/probo/pkg/filemanager"
|
|
"go.probo.inc/probo/pkg/gid"
|
|
"go.probo.inc/probo/pkg/iam"
|
|
"go.probo.inc/probo/pkg/probo"
|
|
"go.probo.inc/probo/pkg/prosemirror"
|
|
"go.probo.inc/probo/pkg/resourcealias"
|
|
"go.probo.inc/probo/pkg/riskmanagement"
|
|
"go.probo.inc/probo/pkg/server/api/authn"
|
|
"go.probo.inc/probo/pkg/server/api/authz"
|
|
"go.probo.inc/probo/pkg/thirdparty"
|
|
)
|
|
|
|
type Resolver struct {
|
|
proboSvc *probo.Service
|
|
resourceAlias *resourcealias.Service
|
|
thirdPartySvc *thirdparty.Service
|
|
iamSvc *iam.Service
|
|
accessReview *accessreview.Service
|
|
cookieBanner *cookiebanner.Service
|
|
riskManagement *riskmanagement.Service
|
|
logger *log.Logger
|
|
fileManager *filemanager.Service
|
|
baseURL *baseurl.BaseURL
|
|
}
|
|
|
|
func markdownToProseMirrorJSON(markdown string) (string, error) {
|
|
node, err := prosemirror.ParseMarkdown(markdown)
|
|
if err != nil {
|
|
return "", fmt.Errorf("cannot parse markdown: %w", err)
|
|
}
|
|
|
|
out, err := json.Marshal(node)
|
|
if err != nil {
|
|
return "", fmt.Errorf("cannot marshal prosemirror node: %w", err)
|
|
}
|
|
|
|
return string(out), nil
|
|
}
|
|
|
|
func (r *Resolver) Authorize(ctx context.Context, entityID gid.GID, action iam.Action, opts ...authz.AuthorizeFuncOption) (*coredata.Scope, error) {
|
|
identity := authn.IdentityFromContext(ctx)
|
|
|
|
params := iam.AuthorizeParams{
|
|
Principal: identity.ID,
|
|
Resource: entityID,
|
|
Action: action,
|
|
ResourceAttributes: make(map[string]string),
|
|
}
|
|
|
|
for _, opt := range opts {
|
|
opt(¶ms)
|
|
}
|
|
|
|
scope, err := r.iamSvc.Authorizer.Authorize(ctx, params)
|
|
if err == nil {
|
|
return scope, nil
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrInsufficientPermissions](err); ok {
|
|
return nil, fmt.Errorf("permission denied")
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrInsufficientOAuth2Scope](err); ok {
|
|
return nil, fmt.Errorf("insufficient scope")
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrAssumptionRequired](err); ok {
|
|
return nil, fmt.Errorf("assumption required")
|
|
}
|
|
|
|
if errors.Is(err, coredata.ErrResourceNotFound) {
|
|
return nil, fmt.Errorf("resource not found")
|
|
}
|
|
|
|
r.logger.ErrorCtx(ctx, "cannot authorize MCP request", log.Error(err))
|
|
|
|
return nil, fmt.Errorf("internal server error")
|
|
}
|
|
|
|
func (r *Resolver) AuthorizeBatch(ctx context.Context, entityIDs []gid.GID, action iam.Action) (*coredata.Scope, error) {
|
|
identity := authn.IdentityFromContext(ctx)
|
|
|
|
scope, err := r.iamSvc.Authorizer.AuthorizeBatch(
|
|
ctx,
|
|
iam.AuthorizeBatchParams{
|
|
Principal: identity.ID,
|
|
Resources: entityIDs,
|
|
Action: action,
|
|
},
|
|
)
|
|
if err == nil {
|
|
return scope, nil
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrInsufficientPermissions](err); ok {
|
|
return nil, fmt.Errorf("permission denied")
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrInsufficientOAuth2Scope](err); ok {
|
|
return nil, fmt.Errorf("insufficient scope")
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrAssumptionRequired](err); ok {
|
|
return nil, fmt.Errorf("assumption required")
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrMixedOrganizationBatch](err); ok {
|
|
return nil, fmt.Errorf("mixed-organization batch")
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrEmptyResourceBatch](err); ok {
|
|
return nil, fmt.Errorf("empty resource batch")
|
|
}
|
|
|
|
if _, ok := errors.AsType[*iam.ErrBatchAuthorizationUnsupportedResourceType](err); ok {
|
|
return nil, fmt.Errorf("batch authorization unsupported for resource type")
|
|
}
|
|
|
|
if errors.Is(err, coredata.ErrResourceNotFound) {
|
|
return nil, fmt.Errorf("resource not found")
|
|
}
|
|
|
|
r.logger.ErrorCtx(ctx, "cannot batch authorize MCP request", log.Error(err))
|
|
|
|
return nil, fmt.Errorf("internal server error")
|
|
}
|