Files
probo/pkg/accessreview/drivers/posthog_test.go
Ludovic Vielle 8094e7cfd0 Truncate access review roles with badge list
Long role strings in the access review table broke row layout when
drivers joined many roles into one comma-separated value. Expose
roles as a string array in GraphQL by splitting the stored role at
the API layer, and render the first three roles as badges with a
"+X more" popover for the rest.

Closes ENG-459.

Signed-off-by: Ludovic Vielle <ludovic@probo.com>
2026-06-16 11:25:31 +02:00

189 lines
5.9 KiB
Go

// Copyright (c) 2026 Probo Inc <hello@probo.com>.
//
// Permission to use, copy, modify, and/or distribute this software for any
// purpose with or without fee is hereby granted, provided that the above
// copyright notice and this permission notice appear in all copies.
//
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
// PERFORMANCE OF THIS SOFTWARE.
package drivers
import (
"context"
"io"
"net/http"
"net/http/httptest"
"os"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.probo.inc/probo/pkg/coredata"
)
func TestPostHogDriverListAccounts(t *testing.T) {
t.Parallel()
rec := newRecorder(t, "testdata/posthog", "POSTHOG_PERSONAL_API_KEY")
client := newVCRClient(rec, bearerAuth(os.Getenv("POSTHOG_PERSONAL_API_KEY")))
records, err := NewPostHogDriver(client, "https://us.posthog.com").ListAccounts(context.Background())
require.NoError(t, err)
require.Len(t, records, 3)
owner := records[0]
assert.Equal(t, "owner@example.com", owner.Email)
assert.Equal(t, "Olivia Owner", owner.FullName)
assert.Equal(t, []string{"Owner"}, owner.Roles)
assert.True(t, owner.IsAdmin)
assert.Equal(t, coredata.MFAStatusEnabled, owner.MFAStatus)
assert.Equal(t, "user-1", owner.ExternalID)
require.NotNil(t, owner.CreatedAt)
require.NotNil(t, owner.LastLogin)
member := records[1]
assert.Equal(t, "member@example.com", member.Email)
assert.Equal(t, []string{"Member"}, member.Roles)
assert.False(t, member.IsAdmin)
assert.Equal(t, coredata.MFAStatusDisabled, member.MFAStatus)
require.NotNil(t, member.CreatedAt)
assert.Nil(t, member.LastLogin)
admin := records[2]
assert.Equal(t, "admin@example.com", admin.Email)
assert.Equal(t, []string{"Admin"}, admin.Roles)
assert.True(t, admin.IsAdmin)
assert.Equal(t, coredata.MFAStatusUnknown, admin.MFAStatus)
assert.Equal(t, "membership-3", admin.ExternalID)
require.NotNil(t, admin.CreatedAt)
}
// TestPostHogDriverResolvesRegionLazily covers the OAuth path: an empty
// baseURL means the region-agnostic gateway was used for the handshake, so
// the driver must discover the data region (us/eu) by probing before listing.
func TestPostHogDriverResolvesRegionLazily(t *testing.T) {
t.Parallel()
resp := func(status int, body string) *http.Response {
return &http.Response{
StatusCode: status,
Body: io.NopCloser(strings.NewReader(body)),
Header: make(http.Header),
}
}
const euMembers = `{"count":1,"next":"","results":[{"id":"m1","user":{"uuid":"u1","first_name":"A","last_name":"B","email":"a@b.com"},"level":1,"joined_at":"2025-01-01T00:00:00Z"}]}`
t.Run("empty base URL probes US then falls back to EU", func(t *testing.T) {
t.Parallel()
var usHits, euHits int
client := &http.Client{Transport: roundTripFunc(func(req *http.Request) (*http.Response, error) {
switch req.URL.Host {
case "us.posthog.com":
usHits++
return resp(http.StatusUnauthorized, `{"detail":"unauthorized"}`), nil
case "eu.posthog.com":
euHits++
return resp(http.StatusOK, euMembers), nil
default:
return resp(http.StatusNotFound, ""), nil
}
})}
records, err := NewPostHogDriver(client, "").ListAccounts(context.Background())
require.NoError(t, err)
require.Len(t, records, 1)
assert.Equal(t, "a@b.com", records[0].Email)
assert.Positive(t, usHits, "US region must be probed")
assert.Positive(t, euHits, "EU region must be used after US refuses")
})
t.Run("no region accepts the token returns an error", func(t *testing.T) {
t.Parallel()
client := &http.Client{Transport: roundTripFunc(func(_ *http.Request) (*http.Response, error) {
return resp(http.StatusForbidden, `{"detail":"forbidden"}`), nil
})}
_, err := NewPostHogDriver(client, "").ListAccounts(context.Background())
require.Error(t, err)
assert.Contains(t, err.Error(), "cannot resolve posthog region")
})
}
func TestPostHogNameResolver(t *testing.T) {
t.Parallel()
cases := []struct {
name string
status int
body string
want string
wantErr bool
}{
{
name: "200 returns name",
status: http.StatusOK,
body: `{"id":"org-1","name":"Acme Inc","slug":"acme"}`,
want: "Acme Inc",
},
{
name: "401 is terminal (no error, no name)",
status: http.StatusUnauthorized,
body: `{"detail":"Authentication credentials were not provided."}`,
want: "",
},
{
name: "404 is terminal (no error, no name)",
status: http.StatusNotFound,
body: `{"detail":"Not found."}`,
want: "",
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodGet, r.Method)
assert.Equal(t, "/api/organizations/@current/", r.URL.Path)
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(tc.status)
_, _ = w.Write([]byte(tc.body))
}))
defer srv.Close()
client := &http.Client{Transport: &hostRewriter{target: srv.URL}}
got, err := NewPostHogNameResolver(client, "https://us.posthog.com").ResolveInstanceName(context.Background())
if tc.wantErr {
require.Error(t, err)
return
}
require.NoError(t, err)
assert.Equal(t, tc.want, got)
})
}
}
func TestPostHogRolesFallback(t *testing.T) {
t.Parallel()
assert.Equal(t, []string{"Owner"}, posthogRoles(15, ""))
assert.Equal(t, []string{"Admin"}, posthogRoles(8, ""))
assert.Equal(t, []string{"Member"}, posthogRoles(1, ""))
assert.Equal(t, []string{"engineering"}, posthogRoles(0, "engineering"))
assert.Equal(t, []string{"Member"}, posthogRoles(0, ""))
}