0920785bdf
Implement Metabase as a first-class access review connector backed by GET /api/user, including account mapping and error handling in the driver. Register the provider with API-key auth metadata and required instance URL settings so connectors can be created and resolved consistently. Expose Metabase through the console GraphQL and UI flows by adding the provider enum value, API-key extra setting field wiring, and source label mapping. Add migration support for the connector_provider enum and cover driver/provider behavior with focused tests. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr> Signed-off-by: Cursor Agent <cursoragent@cursor.com>
103 lines
3.4 KiB
Go
103 lines
3.4 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
|
|
//
|
|
// Permission to use, copy, modify, and/or distribute this software for any
|
|
// purpose with or without fee is hereby granted, provided that the above
|
|
// copyright notice and this permission notice appear in all copies.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
|
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
|
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
|
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
|
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
|
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
|
// PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
package provider_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.gearno.de/kit/httpclient"
|
|
"go.probo.inc/probo/pkg/accessreview/drivers"
|
|
"go.probo.inc/probo/pkg/connector/provider"
|
|
"go.probo.inc/probo/pkg/coredata"
|
|
)
|
|
|
|
func TestMetabaseRegistrationMetadata(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
r := provider.NewBuiltinRegistry()
|
|
reg, ok := r.Get(coredata.ConnectorProviderMetabase)
|
|
require.True(t, ok, "metabase provider must be registered")
|
|
|
|
assert.Equal(t, "Metabase", reg.DisplayName)
|
|
assert.True(t, reg.SupportsAPIKey)
|
|
assert.Equal(t, "x-api-key", reg.APIKeyHeader)
|
|
require.Len(t, reg.ExtraSettings, 1)
|
|
assert.Equal(t, "instanceUrl", reg.ExtraSettings[0].Key)
|
|
assert.Equal(t, "Instance URL", reg.ExtraSettings[0].Label)
|
|
assert.True(t, reg.ExtraSettings[0].Required)
|
|
}
|
|
|
|
func TestMetabaseNewDriver(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
r := provider.NewBuiltinRegistry()
|
|
reg, ok := r.Get(coredata.ConnectorProviderMetabase)
|
|
require.True(t, ok, "metabase provider must be registered")
|
|
require.NotNil(t, reg.NewDriver, "metabase NewDriver closure must be wired")
|
|
|
|
t.Run("creates driver with valid instance_url", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
raw, err := json.Marshal(&coredata.MetabaseConnectorSettings{
|
|
InstanceURL: "https://metabase.example.test",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
conn := &coredata.Connector{
|
|
Provider: coredata.ConnectorProviderMetabase,
|
|
RawSettings: raw,
|
|
}
|
|
|
|
drv, err := reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
|
|
require.NoError(t, err)
|
|
assert.IsType(t, &drivers.MetabaseDriver{}, drv)
|
|
})
|
|
|
|
t.Run("errors when instance_url is missing", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
conn := &coredata.Connector{
|
|
Provider: coredata.ConnectorProviderMetabase,
|
|
RawSettings: []byte(`{}`),
|
|
}
|
|
|
|
_, err := reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "instance_url is required")
|
|
})
|
|
|
|
t.Run("errors when instance_url is invalid", func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
raw, err := json.Marshal(&coredata.MetabaseConnectorSettings{
|
|
InstanceURL: "ftp://metabase.example.test",
|
|
})
|
|
require.NoError(t, err)
|
|
|
|
conn := &coredata.Connector{
|
|
Provider: coredata.ConnectorProviderMetabase,
|
|
RawSettings: raw,
|
|
}
|
|
|
|
_, err = reg.NewDriver(context.Background(), httpclient.DefaultClient(httpclient.WithSSRFProtection()), conn, nil)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "instance_url must be an http(s) URL")
|
|
})
|
|
}
|