Replace the old PDF/snapshot-based exports for processing activities, Data Protection Impact Assessments and Transfer Impact Assessments with the publish document system. Includes GraphQL mutations, MCP tools, CLI commands, n8n operations, frontend publish dialogs, e2e tests, and prosemirror register templates that mirror the previous PDF layouts. Each register lives as a generated DocumentTypeRegister document on the organization, reused across publishes (the major version bumps on every republish). Approvers can be passed in to create a draft pending approval; otherwise the version is published immediately. The frontend ProcessingActivities page exposes a Publish dropdown per register and a Document link button per active tab, pre-fills the previous default approvers, and navigates to the published document on success. Remove snapshot mode entirely from these three entities: drop snapshotId and sourceId from GraphQL schemas, types, filters, resolvers, MCP spec, frontend routes and pages; remove SnapshotsTypeProcessingActivities from the snapshot registry and delete the ProcessingActivities.Snapshot, ProcessingActivitySnapshotter interface and *.InsertProcessingActivitySnapshots methods. The snapshot_id columns remain in the database but are now filtered out with snapshot_id IS NULL. Add Get/Upsert/Clear GeneratedDocumentID methods on each entity type (ProcessingActivity, DataProtectionImpactAssessment, TransferImpactAssessment) backed by new columns in the generated_documents table, matching the Finding/Obligation pattern. Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
349 lines
8.6 KiB
Go
349 lines
8.6 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@getprobo.com>.
|
|
//
|
|
// Permission to use, copy, modify, and/or distribute this software for any
|
|
// purpose with or without fee is hereby granted, provided that the above
|
|
// copyright notice and this permission notice appear in all copies.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
|
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
|
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
|
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
|
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
|
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
|
// PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
package console_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.probo.inc/probo/e2e/internal/factory"
|
|
"go.probo.inc/probo/e2e/internal/testutil"
|
|
)
|
|
|
|
func TestProcessingActivity_PublishProcessingActivityList(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
owner := testutil.NewClient(t, testutil.RoleOwner)
|
|
|
|
t.Run(
|
|
"publish without approvers publishes immediately",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
owner := testutil.NewClient(t, testutil.RoleOwner)
|
|
|
|
_ = factory.NewProcessingActivity(owner).
|
|
WithName("Test Processing Activity").
|
|
WithLawfulBasis("CONSENT").
|
|
Create()
|
|
|
|
const query = `
|
|
mutation($input: PublishProcessingActivityListInput!) {
|
|
publishProcessingActivityList(input: $input) {
|
|
documentEdge {
|
|
node {
|
|
id
|
|
writeMode
|
|
status
|
|
}
|
|
}
|
|
documentVersionEdge {
|
|
node {
|
|
id
|
|
title
|
|
documentType
|
|
status
|
|
major
|
|
minor
|
|
content
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var result struct {
|
|
PublishProcessingActivityList struct {
|
|
DocumentEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
WriteMode string `json:"writeMode"`
|
|
Status string `json:"status"`
|
|
} `json:"node"`
|
|
} `json:"documentEdge"`
|
|
DocumentVersionEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
Title string `json:"title"`
|
|
DocumentType string `json:"documentType"`
|
|
Status string `json:"status"`
|
|
Major int `json:"major"`
|
|
Minor int `json:"minor"`
|
|
Content string `json:"content"`
|
|
} `json:"node"`
|
|
} `json:"documentVersionEdge"`
|
|
} `json:"publishProcessingActivityList"`
|
|
}
|
|
|
|
err := owner.Execute(
|
|
query,
|
|
map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": owner.GetOrganizationID(),
|
|
},
|
|
},
|
|
&result,
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
doc := result.PublishProcessingActivityList.DocumentEdge.Node
|
|
assert.NotEmpty(t, doc.ID)
|
|
assert.Equal(t, "GENERATED", doc.WriteMode)
|
|
assert.Equal(t, "ACTIVE", doc.Status)
|
|
|
|
ver := result.PublishProcessingActivityList.DocumentVersionEdge.Node
|
|
assert.NotEmpty(t, ver.ID)
|
|
assert.Equal(t, "REGISTER", ver.DocumentType)
|
|
assert.Equal(t, "PUBLISHED", ver.Status)
|
|
assert.Equal(t, 1, ver.Major)
|
|
assert.Equal(t, 0, ver.Minor)
|
|
assert.Contains(t, ver.Content, "Purpose")
|
|
assert.Contains(t, ver.Content, "Test Processing Activity")
|
|
},
|
|
)
|
|
|
|
t.Run(
|
|
"publish with approvers creates draft pending approval",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
_ = factory.NewProcessingActivity(owner).
|
|
WithName("Approval PA").
|
|
WithLawfulBasis("CONSENT").
|
|
Create()
|
|
|
|
const query = `
|
|
mutation($input: PublishProcessingActivityListInput!) {
|
|
publishProcessingActivityList(input: $input) {
|
|
documentVersionEdge {
|
|
node {
|
|
id
|
|
status
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var result struct {
|
|
PublishProcessingActivityList struct {
|
|
DocumentVersionEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
Status string `json:"status"`
|
|
} `json:"node"`
|
|
} `json:"documentVersionEdge"`
|
|
} `json:"publishProcessingActivityList"`
|
|
}
|
|
|
|
err := owner.Execute(
|
|
query,
|
|
map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": owner.GetOrganizationID(),
|
|
"approverIds": []string{owner.GetProfileID().String()},
|
|
},
|
|
},
|
|
&result,
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
ver := result.PublishProcessingActivityList.DocumentVersionEdge.Node
|
|
assert.NotEmpty(t, ver.ID)
|
|
assert.Equal(t, "PENDING_APPROVAL", ver.Status)
|
|
},
|
|
)
|
|
|
|
t.Run(
|
|
"second publish reuses existing document and bumps major version",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
secondOwner := testutil.NewClient(t, testutil.RoleOwner)
|
|
|
|
_ = factory.NewProcessingActivity(secondOwner).
|
|
WithName("Reuse PA").
|
|
WithLawfulBasis("CONSENT").
|
|
Create()
|
|
|
|
const query = `
|
|
mutation($input: PublishProcessingActivityListInput!) {
|
|
publishProcessingActivityList(input: $input) {
|
|
documentEdge {
|
|
node { id }
|
|
}
|
|
documentVersionEdge {
|
|
node { id major }
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var result1, result2 struct {
|
|
PublishProcessingActivityList struct {
|
|
DocumentEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
} `json:"node"`
|
|
} `json:"documentEdge"`
|
|
DocumentVersionEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
Major int `json:"major"`
|
|
} `json:"node"`
|
|
} `json:"documentVersionEdge"`
|
|
} `json:"publishProcessingActivityList"`
|
|
}
|
|
|
|
input := map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": secondOwner.GetOrganizationID(),
|
|
},
|
|
}
|
|
|
|
err := secondOwner.Execute(query, input, &result1)
|
|
require.NoError(t, err)
|
|
|
|
err = secondOwner.Execute(query, input, &result2)
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(
|
|
t,
|
|
result1.PublishProcessingActivityList.DocumentEdge.Node.ID,
|
|
result2.PublishProcessingActivityList.DocumentEdge.Node.ID,
|
|
"should reuse the same document",
|
|
)
|
|
assert.Equal(t, 1, result1.PublishProcessingActivityList.DocumentVersionEdge.Node.Major)
|
|
assert.Equal(t, 2, result2.PublishProcessingActivityList.DocumentVersionEdge.Node.Major)
|
|
},
|
|
)
|
|
|
|
t.Run(
|
|
"document linked back to organization via processingActivitiesDocument",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
thirdOwner := testutil.NewClient(t, testutil.RoleOwner)
|
|
|
|
_ = factory.NewProcessingActivity(thirdOwner).
|
|
WithName("Linked PA").
|
|
WithLawfulBasis("CONSENT").
|
|
Create()
|
|
|
|
const publishQuery = `
|
|
mutation($input: PublishProcessingActivityListInput!) {
|
|
publishProcessingActivityList(input: $input) {
|
|
documentEdge {
|
|
node { id }
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var publishResult struct {
|
|
PublishProcessingActivityList struct {
|
|
DocumentEdge struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
} `json:"node"`
|
|
} `json:"documentEdge"`
|
|
} `json:"publishProcessingActivityList"`
|
|
}
|
|
|
|
err := thirdOwner.Execute(
|
|
publishQuery,
|
|
map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": thirdOwner.GetOrganizationID(),
|
|
},
|
|
},
|
|
&publishResult,
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
docID := publishResult.PublishProcessingActivityList.DocumentEdge.Node.ID
|
|
|
|
const orgQuery = `
|
|
query($id: ID!) {
|
|
node(id: $id) {
|
|
... on Organization {
|
|
id
|
|
processingActivitiesDocument { id }
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
var orgResult struct {
|
|
Node struct {
|
|
ID string `json:"id"`
|
|
ProcessingActivitiesDocument *struct {
|
|
ID string `json:"id"`
|
|
} `json:"processingActivitiesDocument"`
|
|
} `json:"node"`
|
|
}
|
|
|
|
err = thirdOwner.Execute(
|
|
orgQuery,
|
|
map[string]any{"id": thirdOwner.GetOrganizationID()},
|
|
&orgResult,
|
|
)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, orgResult.Node.ProcessingActivitiesDocument)
|
|
assert.Equal(t, docID, orgResult.Node.ProcessingActivitiesDocument.ID)
|
|
},
|
|
)
|
|
}
|
|
|
|
func TestProcessingActivity_PublishProcessingActivityList_RBAC(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
owner := testutil.NewClient(t, testutil.RoleOwner)
|
|
viewer := testutil.NewClientInOrg(t, testutil.RoleViewer, owner)
|
|
|
|
_ = factory.NewProcessingActivity(owner).
|
|
WithName("RBAC PA").
|
|
WithLawfulBasis("CONSENT").
|
|
Create()
|
|
|
|
const query = `
|
|
mutation($input: PublishProcessingActivityListInput!) {
|
|
publishProcessingActivityList(input: $input) {
|
|
documentEdge {
|
|
node { id }
|
|
}
|
|
}
|
|
}
|
|
`
|
|
|
|
t.Run(
|
|
"viewer cannot publish processing activity list",
|
|
func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
err := viewer.ExecuteShouldFail(
|
|
query,
|
|
map[string]any{
|
|
"input": map[string]any{
|
|
"organizationId": owner.GetOrganizationID(),
|
|
},
|
|
},
|
|
)
|
|
testutil.RequireForbiddenError(t, err)
|
|
},
|
|
)
|
|
}
|