Replace pkg/iam/scopeset with pkg/iam/oauth2scope.Registry, a shared OAuth2 scope→action registry used by the authorizer, OAuth2 service, and Connect API. Registration stays open until probod calls Freeze(); read paths (RegisteredScopes, Allows, ValidateScopes) panic before that. Drop the leaky APIScopes surface and AllowedAPIScopes on manual access-token creation in favor of registry.ValidateScopes. Metadata, protected-resource metadata, and CIMD scope lists are built from RegisteredScopes() via helpers in pkg/iam/oauth2/scopes.go. Expose oauth2ScopesSupported as an OAuth2Scope GraphQL scalar. Signed-off-by: Ludovic Vielle <ludovic@probo.com>
59 lines
2.0 KiB
Go
59 lines
2.0 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
|
//
|
|
// Permission to use, copy, modify, and/or distribute this software for any
|
|
// purpose with or without fee is hereby granted, provided that the above
|
|
// copyright notice and this permission notice appear in all copies.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
|
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
|
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
|
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
|
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
|
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
|
// PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
package iam_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"go.probo.inc/probo/pkg/accessreview"
|
|
"go.probo.inc/probo/pkg/agentrun"
|
|
"go.probo.inc/probo/pkg/coredata"
|
|
"go.probo.inc/probo/pkg/iam"
|
|
"go.probo.inc/probo/pkg/iam/oauth2scope"
|
|
"go.probo.inc/probo/pkg/probo"
|
|
)
|
|
|
|
func allRegisteredOAuth2ScopeRegistries() *oauth2scope.Registry {
|
|
return oauth2scope.NewRegistry().
|
|
Register(iam.IAMOAuth2ScopeMappings).
|
|
Register(probo.OAuth2ScopeMappings).
|
|
Register(accessreview.OAuth2ScopeMappings).
|
|
Register(agentrun.OAuth2ScopeMappings)
|
|
}
|
|
|
|
func TestRegisteredOAuth2ScopeRegistries_OrganizationRead(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
reg := allRegisteredOAuth2ScopeRegistries()
|
|
tokenScopes := coredata.OAuth2Scopes{probo.ScopeV1OrgRead}
|
|
|
|
assert.True(t, reg.Allows(tokenScopes, probo.ActionOrganizationGet))
|
|
assert.False(t, reg.Allows(tokenScopes, probo.ActionOrganizationUpdate))
|
|
assert.False(t, reg.Allows(tokenScopes, probo.ActionThirdPartyList))
|
|
}
|
|
|
|
func TestRegisteredOAuth2ScopeRegistries_UnmappedActionDenies(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
reg := allRegisteredOAuth2ScopeRegistries()
|
|
tokenScopes := coredata.OAuth2Scopes{
|
|
probo.ScopeV1OrgRead,
|
|
probo.ScopeV1ThirdPartyRead,
|
|
}
|
|
|
|
assert.False(t, reg.Allows(tokenScopes, "core:unmapped:action"))
|
|
}
|