Files
probo/pkg/server/api/console/v1/connector_settings_test.go
Aurélien Sibiril fb68e98941 Split connector extra settings per credential path
Registration.ExtraSettings was a single flat list, but the API-key and
client-credentials connect dialogs need different fields whenever a
provider offers both paths, because a different create resolver and a
different driver sits behind each. Replace it with
APIKeyExtraSettings and ClientCredentialsExtraSettings, and split the
GraphQL surface to match so a client cannot render one path's settings
on the other.

This fixes two connectors that could not be connected at all.

1Password declared accountId and region only, which are the
client-credentials shape. The API-key dialog therefore rendered those
two fields, mapAPIKeyExtraSettingToField returned nil for both so
buildExtraFields discarded them, and the SCIM-bridge driver failed on an
empty SCIMBridgeURL. The console already mapped scimBridgeUrl, but no
registration declared that key, so the branch was dead. It now declares
scimBridgeUrl on the API-key path and accountId + region on client
credentials.

Langfuse declared baseUrl as required, but mapAPIKeyExtraSettingToField
had no LANGFUSE case, so buildExtraFields dropped the value the customer
typed and the mutation failed with "langfuseBaseUrl is required". Every
other extra-settings provider had a case. The GraphQL input field, the
settings struct, the probe builder and the driver were all already
correct; only the console mapping was missing.

buildExtraFields now takes the settings list explicitly instead of
reading it off the provider, so each dialog passes its own path's list
and cannot silently iterate the other one.

Register rejects a settings list for a path the provider does not offer,
and an empty or duplicate setting key within one list. A key repeated
across the two lists is allowed: that is how a dual-path provider
declares a setting both dialogs need.

The new resolver tests walk the whole chain the console walks, from the
key a Registration declares through the mutation input field to the
persisted settings struct, so a key renamed on one side and not the
other fails in CI instead of at connect time.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
2026-07-26 15:56:10 +02:00

126 lines
4.8 KiB
Go

// Copyright (c) 2026 Probo Inc <hello@probo.com>.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
package console_v1
import (
"encoding/json"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.probo.inc/probo/pkg/connector/provider"
"go.probo.inc/probo/pkg/coredata"
"go.probo.inc/probo/pkg/server/api/console/v1/types"
)
// Langfuse and 1Password are the two providers whose declared settings failed
// to reach these resolvers: the console dropped Langfuse's Base URL, and
// 1Password's single flat list made the API-key dialog collect the
// client-credentials fields. Each test below walks the whole chain the console
// walks — the key a Registration declares, the mutation input field it is
// submitted as, the settings struct that is persisted — so a key renamed on one
// side and not the other fails here instead of at connect time.
func TestApiKeyConnectorSettings_LangfuseBaseURL(t *testing.T) {
t.Parallel()
reg, ok := provider.NewBuiltinRegistry().Get(coredata.ConnectorProviderLangfuse)
require.True(t, ok)
require.Len(t, reg.APIKeyExtraSettings, 1)
require.Equal(t, "baseUrl", reg.APIKeyExtraSettings[0].Key)
baseURL := "https://cloud.langfuse.com"
raw, err := apiKeyConnectorSettings(types.CreateAPIKeyConnectorInput{
Provider: coredata.ConnectorProviderLangfuse,
LangfuseBaseURL: &baseURL,
})
require.NoError(t, err)
var settings coredata.LangfuseConnectorSettings
require.NoError(t, json.Unmarshal(raw, &settings))
assert.Equal(t, baseURL, settings.BaseURL)
_, err = apiKeyConnectorSettings(types.CreateAPIKeyConnectorInput{
Provider: coredata.ConnectorProviderLangfuse,
})
require.Error(t, err)
}
func TestApiKeyConnectorSettings_OnePasswordSCIMBridgeURL(t *testing.T) {
t.Parallel()
reg, ok := provider.NewBuiltinRegistry().Get(coredata.ConnectorProviderOnePassword)
require.True(t, ok)
require.Len(t, reg.APIKeyExtraSettings, 1)
require.Equal(t, "scimBridgeUrl", reg.APIKeyExtraSettings[0].Key)
scimBridgeURL := "https://scim.example.test"
raw, err := apiKeyConnectorSettings(types.CreateAPIKeyConnectorInput{
Provider: coredata.ConnectorProviderOnePassword,
OnePasswordScimBridgeURL: &scimBridgeURL,
})
require.NoError(t, err)
var settings coredata.OnePasswordConnectorSettings
require.NoError(t, json.Unmarshal(raw, &settings))
assert.Equal(t, scimBridgeURL, settings.SCIMBridgeURL)
// The old shared settings list made this dialog collect Account ID and
// Region instead, which CreateAPIKeyConnectorInput has no fields for at
// all: whatever the customer typed was dropped and the create failed here.
_, err = apiKeyConnectorSettings(types.CreateAPIKeyConnectorInput{
Provider: coredata.ConnectorProviderOnePassword,
})
require.Error(t, err)
}
func TestClientCredentialsConnectorSettings_OnePassword(t *testing.T) {
t.Parallel()
reg, ok := provider.NewBuiltinRegistry().Get(coredata.ConnectorProviderOnePassword)
require.True(t, ok)
require.Len(t, reg.ClientCredentialsExtraSettings, 2)
require.Equal(t, "accountId", reg.ClientCredentialsExtraSettings[0].Key)
require.Equal(t, "region", reg.ClientCredentialsExtraSettings[1].Key)
accountID, region := "acme", "EU"
raw, err := clientCredentialsConnectorSettings(types.CreateClientCredentialsConnectorInput{
Provider: coredata.ConnectorProviderOnePassword,
OnePasswordAccountID: &accountID,
OnePasswordRegion: &region,
})
require.NoError(t, err)
var settings coredata.OnePasswordUsersAPISettings
require.NoError(t, json.Unmarshal(raw, &settings))
assert.Equal(t, accountID, settings.AccountID)
assert.Equal(t, region, settings.Region)
_, err = clientCredentialsConnectorSettings(types.CreateClientCredentialsConnectorInput{
Provider: coredata.ConnectorProviderOnePassword,
OnePasswordAccountID: &accountID,
})
require.Error(t, err)
}