Replace presigned URL string fields (logoUrl, fileUrl, ndaFileName, etc.) with nested File references resolved through /api/files/v1/. Update console Relay queries and e2e coverage accordingly. Route NDA upload through filemanager.PutFile and return stable IAM org logo URLs for consistency with the files API. Signed-off-by: Ludovic Vielle <ludovic@probo.com>
69 lines
2.2 KiB
Go
69 lines
2.2 KiB
Go
// Copyright (c) 2026 Probo Inc <hello@probo.com>.
|
|
//
|
|
// Permission to use, copy, modify, and/or distribute this software for any
|
|
// purpose with or without fee is hereby granted, provided that the above
|
|
// copyright notice and this permission notice appear in all copies.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
|
|
// REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
|
|
// AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
|
|
// INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
|
|
// LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
|
|
// OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
|
|
// PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
package filemanager_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"go.probo.inc/probo/pkg/baseurl"
|
|
"go.probo.inc/probo/pkg/coredata"
|
|
"go.probo.inc/probo/pkg/filemanager"
|
|
"go.probo.inc/probo/pkg/gid"
|
|
)
|
|
|
|
func TestDownloadAPIPath_IncludesPublicSegmentForPublicFiles(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
file := &coredata.File{
|
|
ID: gid.New(gid.NilTenant, coredata.FileEntityType),
|
|
Visibility: coredata.FileVisibilityPublic,
|
|
}
|
|
|
|
assert.Equal(t, "/api/files/v1/public/"+file.ID.String(), filemanager.DownloadAPIPath(file))
|
|
}
|
|
|
|
func TestDownloadAPIPath_UsesPrivateSegmentForPrivateFiles(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
file := &coredata.File{
|
|
ID: gid.New(gid.NilTenant, coredata.FileEntityType),
|
|
Visibility: coredata.FileVisibilityPrivate,
|
|
}
|
|
|
|
assert.Equal(t, "/api/files/v1/"+file.ID.String(), filemanager.DownloadAPIPath(file))
|
|
}
|
|
|
|
func TestGenerateFileURL_PathIncludesPublicSegment(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
base, err := baseurl.Parse("https://app.example.com")
|
|
if err != nil {
|
|
t.Fatalf("cannot parse base URL: %v", err)
|
|
}
|
|
|
|
file := &coredata.File{
|
|
ID: gid.New(gid.NilTenant, coredata.FileEntityType),
|
|
Visibility: coredata.FileVisibilityPublic,
|
|
}
|
|
|
|
url, err := base.AppendPath(filemanager.DownloadAPIPath(file)).String()
|
|
if err != nil {
|
|
t.Fatalf("cannot build URL: %v", err)
|
|
}
|
|
|
|
assert.Equal(t, "https://app.example.com/api/files/v1/public/"+file.ID.String(), url)
|
|
}
|