The public trust API derived its authorization scope from client-supplied global IDs, so a visitor on one trust center could resolve nodes, export audit-report PDFs, and read or mutate electronic signatures belonging to another organization (cross-tenant access). Every trust API resolver now derives its scope from the active compliance page's organization via compliancepage.ScopeFromContext, so reads are always confined to the page's tenant. Cross-tenant or unknown IDs surface as not-found instead of leaking data or returning a 500. Active/presence is enforced upstream by the id and presence middlewares. esign's signature operations (GetSignatureByID, AcceptSignature, RecordEvent) now take a caller-provided scope instead of deriving one from the requested ID, so signature reads and mutations are tenant-scoped at the source. This removes the need for a resolver-level authorization helper; RecordEvent also verifies signature ownership within scope before recording, since the event foreign key is not tenant-composite. Adds e2e non-regression tests covering owning vs. foreign trust center report export and the generic node(id:) resolver. Signed-off-by: Sacha Al Himdani <sacha@probo.com>
160 lines
5.3 KiB
Go
160 lines
5.3 KiB
Go
package trust_v1
|
|
|
|
// This file will be automatically regenerated based on the schema, any resolver
|
|
// implementations
|
|
// will be copied through when generating and any unknown code will be moved to the end.
|
|
// Code generated by github.com/99designs/gqlgen version v0.17.93
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"time"
|
|
|
|
"go.gearno.de/kit/log"
|
|
"go.probo.inc/probo/pkg/coredata"
|
|
"go.probo.inc/probo/pkg/esign"
|
|
"go.probo.inc/probo/pkg/server/api/authn"
|
|
"go.probo.inc/probo/pkg/server/api/clientip"
|
|
"go.probo.inc/probo/pkg/server/api/compliancepage"
|
|
"go.probo.inc/probo/pkg/server/api/trust/v1/schema"
|
|
"go.probo.inc/probo/pkg/server/api/trust/v1/types"
|
|
"go.probo.inc/probo/pkg/server/gqlutils"
|
|
)
|
|
|
|
// AcceptElectronicSignature is the resolver for the acceptElectronicSignature field.
|
|
func (r *mutationResolver) AcceptElectronicSignature(ctx context.Context, input types.AcceptElectronicSignatureInput) (*types.AcceptElectronicSignaturePayload, error) {
|
|
var (
|
|
identity = authn.IdentityFromContext(ctx)
|
|
httpReq = gqlutils.HTTPRequestFromContext(ctx)
|
|
compliancePage = compliancepage.CompliancePageFromContext(ctx)
|
|
scope = coredata.NewScopeFromObjectID(compliancePage.OrganizationID)
|
|
)
|
|
|
|
signerIP := clientip.Extract(httpReq)
|
|
|
|
signature, err := r.esign.AcceptSignature(
|
|
ctx,
|
|
scope,
|
|
&esign.AcceptSignatureRequest{
|
|
SignatureID: input.SignatureID,
|
|
SignerFullName: identity.FullName,
|
|
SignerEmail: identity.EmailAddress,
|
|
SignerIPAddr: signerIP,
|
|
SignerUA: httpReq.UserAgent(),
|
|
},
|
|
)
|
|
if err != nil {
|
|
if errors.Is(err, esign.ErrElectronicSignatureNotFound) {
|
|
return nil, gqlutils.NotFoundf(ctx, "electronic signature %q not found", input.SignatureID)
|
|
}
|
|
|
|
r.logger.ErrorCtx(ctx, "cannot accept electronic signature", log.Error(err))
|
|
|
|
return nil, gqlutils.Internal(ctx)
|
|
}
|
|
|
|
return &types.AcceptElectronicSignaturePayload{
|
|
Signature: types.NewElectronicSignature(signature),
|
|
}, nil
|
|
}
|
|
|
|
// RecordSigningEvent is the resolver for the recordSigningEvent field.
|
|
func (r *mutationResolver) RecordSigningEvent(ctx context.Context, input types.RecordSigningEventInput) (*types.RecordSigningEventPayload, error) {
|
|
var (
|
|
identity = authn.IdentityFromContext(ctx)
|
|
httpReq = gqlutils.HTTPRequestFromContext(ctx)
|
|
compliancePage = compliancepage.CompliancePageFromContext(ctx)
|
|
scope = coredata.NewScopeFromObjectID(compliancePage.OrganizationID)
|
|
)
|
|
|
|
actorIP := clientip.Extract(httpReq)
|
|
|
|
if err := r.esign.RecordEvent(
|
|
ctx,
|
|
scope,
|
|
&esign.RecordEventRequest{
|
|
SignatureID: input.SignatureID,
|
|
EventType: input.EventType,
|
|
EventSource: coredata.ElectronicSignatureEventSourceClient,
|
|
ActorEmail: identity.EmailAddress,
|
|
ActorIPAddr: actorIP,
|
|
ActorUA: httpReq.UserAgent(),
|
|
},
|
|
); err != nil {
|
|
if errors.Is(err, esign.ErrElectronicSignatureNotFound) {
|
|
return nil, gqlutils.NotFoundf(ctx, "electronic signature %q not found", input.SignatureID)
|
|
}
|
|
|
|
r.logger.ErrorCtx(ctx, "cannot record signing event", log.Error(err))
|
|
|
|
return nil, gqlutils.Internal(ctx)
|
|
}
|
|
|
|
return &types.RecordSigningEventPayload{Success: true}, nil
|
|
}
|
|
|
|
// FileURL is the resolver for the fileUrl field.
|
|
func (r *nonDisclosureAgreementResolver) FileURL(ctx context.Context, obj *types.NonDisclosureAgreement) (string, error) {
|
|
compliancePage := compliancepage.CompliancePageFromContext(ctx)
|
|
|
|
if identity := authn.IdentityFromContext(ctx); identity != nil && r.esign != nil {
|
|
scope := coredata.NewScopeFromObjectID(compliancePage.OrganizationID)
|
|
trustService := r.trust
|
|
|
|
access, err := trustService.TrustCenterAccesses.GetAccess(ctx, scope, compliancePage.ID, identity.ID)
|
|
if err == nil && access.ElectronicSignatureID != nil {
|
|
fileURL, err := r.esign.GenerateSignatureFileURL(ctx, *access.ElectronicSignatureID, 15*time.Minute)
|
|
if err == nil {
|
|
return fileURL, nil
|
|
}
|
|
|
|
r.logger.ErrorCtx(ctx, "cannot generate signature file URL, falling back to original NDA", log.Error(err))
|
|
}
|
|
}
|
|
|
|
scope := coredata.NewScopeFromObjectID(compliancePage.OrganizationID)
|
|
trustService := r.trust
|
|
|
|
fileURL, err := trustService.TrustCenters.GenerateNDAFileURL(ctx, scope, compliancePage.ID, 15*time.Minute)
|
|
if err != nil {
|
|
return "", gqlutils.Internal(ctx)
|
|
}
|
|
|
|
return fileURL, nil
|
|
}
|
|
|
|
// ViewerSignature is the resolver for the viewerSignature field.
|
|
func (r *nonDisclosureAgreementResolver) ViewerSignature(ctx context.Context, obj *types.NonDisclosureAgreement) (*types.ElectronicSignature, error) {
|
|
identity := authn.IdentityFromContext(ctx)
|
|
if identity == nil {
|
|
return nil, nil
|
|
}
|
|
|
|
compliancePage := compliancepage.CompliancePageFromContext(ctx)
|
|
scope := coredata.NewScopeFromObjectID(compliancePage.OrganizationID)
|
|
trustService := r.trust
|
|
|
|
access, err := trustService.TrustCenterAccesses.GetAccess(ctx, scope, compliancePage.ID, identity.ID)
|
|
if err != nil {
|
|
return nil, nil
|
|
}
|
|
|
|
if access.ElectronicSignatureID == nil {
|
|
return nil, nil
|
|
}
|
|
|
|
sig, err := r.esign.GetSignatureByID(ctx, scope, *access.ElectronicSignatureID)
|
|
if err != nil {
|
|
return nil, nil
|
|
}
|
|
|
|
return types.NewElectronicSignature(sig), nil
|
|
}
|
|
|
|
// NonDisclosureAgreement returns schema.NonDisclosureAgreementResolver implementation.
|
|
func (r *Resolver) NonDisclosureAgreement() schema.NonDisclosureAgreementResolver {
|
|
return &nonDisclosureAgreementResolver{r}
|
|
}
|
|
|
|
type nonDisclosureAgreementResolver struct{ *Resolver }
|